linux-kernel - RE: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5678C68754B7CC837E947F41C98F2@SJ0PR11MB5678.namprd11.prod.outlook.com>
Date: Thu, 22 Aug 2024 16:19:41 +0000
From: "Sridhar, Kanchana P" <kanchana.p.sridhar@...el.com>
To: Michal Hocko <mhocko@...e.com>
CC: Nhat Pham <nphamcs@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"hannes@...xchg.org" <hannes@...xchg.org>, "yosryahmed@...gle.com"
	<yosryahmed@...gle.com>, "ryan.roberts@....com" <ryan.roberts@....com>,
	"Huang, Ying" <ying.huang@...el.com>, "21cnbao@...il.com"
	<21cnbao@...il.com>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"Zou, Nanhai" <nanhai.zou@...el.com>, "Feghali, Wajdi K"
	<wajdi.k.feghali@...el.com>, "Gopal, Vinodh" <vinodh.gopal@...el.com>,
	"Sridhar, Kanchana P" <kanchana.p.sridhar@...el.com>
Subject: RE: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG_MEMCG is not
 defined.


> -----Original Message-----
> From: Michal Hocko <mhocko@...e.com>
> Sent: Wednesday, August 21, 2024 11:15 PM
> To: Sridhar, Kanchana P <kanchana.p.sridhar@...el.com>
> Cc: Nhat Pham <nphamcs@...il.com>; linux-kernel@...r.kernel.org; linux-
> mm@...ck.org; hannes@...xchg.org; yosryahmed@...gle.com;
> ryan.roberts@....com; Huang, Ying <ying.huang@...el.com>;
> 21cnbao@...il.com; akpm@...ux-foundation.org; Zou, Nanhai
> <nanhai.zou@...el.com>; Feghali, Wajdi K <wajdi.k.feghali@...el.com>;
> Gopal, Vinodh <vinodh.gopal@...el.com>
> Subject: Re: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG_MEMCG is
> not defined.
> 
> On Wed 21-08-24 19:40:42, Sridhar, Kanchana P wrote:
> >
> > > -----Original Message-----
> > > From: Nhat Pham <nphamcs@...il.com>
> > > Sent: Wednesday, August 21, 2024 12:24 PM
> > > To: Sridhar, Kanchana P <kanchana.p.sridhar@...el.com>
> > > Cc: linux-kernel@...r.kernel.org; linux-mm@...ck.org;
> > > hannes@...xchg.org; yosryahmed@...gle.com;
> ryan.roberts@....com;
> > > Huang, Ying <ying.huang@...el.com>; 21cnbao@...il.com; akpm@...ux-
> > > foundation.org; Zou, Nanhai <nanhai.zou@...el.com>; Feghali, Wajdi K
> > > <wajdi.k.feghali@...el.com>; Gopal, Vinodh <vinodh.gopal@...el.com>
> > > Subject: Re: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG_MEMCG
> is
> > > not defined.
> > >
> > > On Tue, Aug 20, 2024 at 3:50 PM Kanchana P Sridhar
> > > <kanchana.p.sridhar@...el.com> wrote:
> > > >
> > > > This resolves an issue with obj_cgroup_get() not being defined
> > > > if CONFIG_MEMCG is not defined. This causes build errors if
> > > > obj_cgroup_get() is called from code that is agnostic of
> CONFIG_MEMCG.
> > > >
> > > > The patch resolves this.
> > > >
> > > > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
> > > > ---
> > >
> > > This is only exposed because of your zswap mTHP patch series right?
> > > Could you include this patch as part of that series (since we don't
> > > need this without that patch series), or make it clear in the change
> > > log?
> >
> > That's correct, Nhat. Although, it might be useful to have obj_cgroup_get()
> > defined in the case where CONFIG_MEMCG is not defined. memcontrol.h
> > handles obj_cgroup_put() similarly. Would it be Ok if I included a reference
> > to the zswap mTHP patch series in the change log?
> 
> I would just fold it into the patch which exposes use without
> CONFIG_MEMCG. We currently do not have any such user. That's why I've
> asked what is this patch based on.

Ok, this sounds good, Michal and Nhat.

Thanks,
Kanchana

> --
> Michal Hocko
> SUSE Labs