linux-kernel - Re: [PATCH v2 0/2] scsi: ufs: introduce a callback to override OCS value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e7e0a2e-39e3-47d1-adc4-24b7e9761b5f@acm.org>
Date: Thu, 22 Aug 2024 09:26:04 -0700
From: Bart Van Assche <bvanassche@....org>
To: Bean Huo <huobean@...il.com>, Kiwoong Kim <kwmad.kim@...sung.com>,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 alim.akhtar@...sung.com, avri.altman@....com, jejb@...ux.ibm.com,
 martin.petersen@...cle.com, beanhuo@...ron.com, adrian.hunter@...el.com,
 h10.kim@...sung.com, hy50.seo@...sung.com, sh425.lee@...sung.com,
 kwangwon.min@...sung.com, junwoo80.lee@...sung.com, wkon.kim@...sung.com
Subject: Re: [PATCH v2 0/2] scsi: ufs: introduce a callback to override OCS
 value

On 8/22/24 8:42 AM, Bean Huo wrote:
> On Thu, 2024-08-22 at 20:15 +0900, Kiwoong Kim wrote:
>> Kiwoong Kim (2):
>>    scsi: ufs: core: introduce override_cqe_ocs
>>    scsi: ufs: ufs-exynos: implement override_cqe_ocs
> 
> 
> Hi Kiwoong Kim,
> 
> I didn't see your patch email,just post your second patch here, and
> provide my comments:
> 
>   
> +static enum utp_ocs exynos_ufs_override_cqe_ocs(enum utp_ocs ocs)
> +{
> +	if (ocs == OCS_ABORTED)
> +		ocs = OCS_INVALID_COMMAND_STATUS;
> +	return ocs;
> +}
> 
> 
> I wonder if you have considered the case where the command is aborted
> by the host software or by the device itself?
> 
> If you change OCS to OCS_INVALID_COMMAND_STATUS, there will report a
> DID_REQUEUE to SCSI.

The decision about what to do probably should depend on whether or not
the command has been nullified.

Thanks,

Bart.