linux-kernel - Re: [PATCH] soc: fsl: qbman: Remove redundant warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3241a692-088d-4316-85c9-f2939a9179b2@csgroup.eu>
Date: Thu, 22 Aug 2024 18:55:18 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Xiaolei Wang <xiaolei.wang@...driver.com>, robh@...nel.org
Cc: linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: fsl: qbman: Remove redundant warnings

Hi,

Le 02/08/2024 à 04:16, Xiaolei Wang a écrit :
> [Vous ne recevez pas souvent de courriers de xiaolei.wang@...driver.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> RESERVEDMEM_OF_DECLARE usage has been removed. For
> non-popwerpc platforms, such as ls1043, this warning
> is redundant. ls1043 itself uses shared-dma-mem.

Can you please explain in more details ? I don't understand what it is 
redundant with.

Thanks
Christophe

> 
> Fixes: 3e62273ac63a ("soc: fsl: qbman: Remove RESERVEDMEM_OF_DECLARE usage")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@...driver.com>
> ---
>   drivers/soc/fsl/qbman/qman_ccsr.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qbman/qman_ccsr.c b/drivers/soc/fsl/qbman/qman_ccsr.c
> index 392e54f14dbe..aa5348f4902f 100644
> --- a/drivers/soc/fsl/qbman/qman_ccsr.c
> +++ b/drivers/soc/fsl/qbman/qman_ccsr.c
> @@ -791,8 +791,6 @@ static int fsl_qman_probe(struct platform_device *pdev)
>           * FQD memory MUST be zero'd by software
>           */
>          zero_priv_mem(fqd_a, fqd_sz);
> -#else
> -       WARN(1, "Unexpected architecture using non shared-dma-mem reservations");
>   #endif
>          dev_dbg(dev, "Allocated FQD 0x%llx 0x%zx\n", fqd_a, fqd_sz);
> 
> --
> 2.25.1
>