linux-kernel - Re: [PATCH v1] mm:slab:use kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bb9fcbc-310a-ad36-9e96-61dc80681f12@gentwo.org>
Date: Thu, 22 Aug 2024 09:59:29 -0700 (PDT)
From: "Christoph Lameter (Ampere)" <cl@...two.org>
To: Yan Zhen <yanzhen@...o.com>
cc: penberg@...nel.org, rientjes@...gle.com, iamjoonsoo.kim@....com, 
    akpm@...ux-foundation.org, vbabka@...e.cz, roman.gushchin@...ux.dev, 
    42.hyeyoo@...il.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
    opensource.kernel@...o.com
Subject: Re: [PATCH v1] mm:slab:use kmem_cache_free() to free

On Thu, 22 Aug 2024, Yan Zhen wrote:

> The kmem_cache_alloc() is typically used to free memory allocated through
> the kernel memory cache (slab allocator).

Well yes but since we removed SLOB we can use kfree() on any slab object.

> Using kmem_cache_free() for deallocation may be more reasonable.


It is more symmetric and looks better.

Reviewed-by: Christoph Lameter <cl@...ux.com>