| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAG-pW8EgBE4RwhcFtMXEuFtG56JJSyvOjG5+q71zG6pJyo05hg@mail.gmail.com>
Date: Fri, 23 Aug 2024 01:09:06 +0400
From: Pavel Nikulin <pavel@...-labs.com>
To: Chris Lu (陸稚泓) <Chris.Lu@...iatek.com>
Cc: "luiz.dentz@...il.com" <luiz.dentz@...il.com>, "marcel@...tmann.org" <marcel@...tmann.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
Deren Wu (武德仁) <Deren.Wu@...iatek.com>,
"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
"johan.hedberg@...il.com" <johan.hedberg@...il.com>, Steve Lee (李視誠) <steve.lee@...iatek.com>,
Sean Wang <Sean.Wang@...iatek.com>, Aaron Hou (侯俊仰) <Aaron.Hou@...iatek.com>
Subject: Re: [PATCH] Bluetooth: btusb: Add Realtek MT7925 support ID 0x13d3:0x3608
Oh my, how I missed that.
I think a commit can be undone, and the same patch with a correct
commit message submitted again. Somebody with access will have to
revert it.
Pavel Nikulin
Senior Engineer
+971 52 386 6738
pavel@...-labs.com
On Thu, Aug 22, 2024 at 9:54 AM Chris Lu (陸稚泓) <Chris.Lu@...iatek.com> wrote:
>
> Hi Luiz and Pavel,
>
> I think these is something wrong to the title and content of this
> patch. MT7925 is an connectivity IC from Mediatek rather than Realtek.
>
> Although this patch has been accpeted and merged to the next tree, I'm
> wondering if the typo can still be fixed? I'm afraid that such error
> could cause some misunderstanding to users.
>
> Thanks a lot!
>
> BRs,
> Chris
>
> On Wed, 2024-08-21 at 15:08 +0400, Pavel Nikulin wrote:
> > Add the support ID (0x13d3, 0x3608) to usb_device_id table for
> > Realtek MT7925B14L found on AW-EM637 WiFi+BT modules in 2024 Asus
> > laptops.
> >
> > The device info from /sys/kernel/debug/usb/devices as below.
> >
> > T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
> > P: Vendor=13d3 ProdID=3608 Rev= 1.00
> > S: Manufacturer=MediaTek Inc.
> > S: Product=Wireless_Device
> > S: SerialNumber=000000000
> > C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA
> > A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01
> > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us
> > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> > I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> > I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> > I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
> > I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
> > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> > I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> > E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms
> > I: If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us
> > E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us
> > I:* If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E: Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us
> > E: Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125us
> >
> > Signed-off-by: Pavel Nikulin <pavel@...-labs.com>
> > ---
> > drivers/bluetooth/btusb.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index bb698ca98..df0d2e4ab 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -627,6 +627,8 @@ static const struct usb_device_id quirks_table[]
> > = {
> > BTUSB_WIDEBAND_SPE
> > ECH },
> > { USB_DEVICE(0x13d3, 0x3604), .driver_info = BTUSB_MEDIATEK |
> > BTUSB_WIDEBAND_SPE
> > ECH },
> > +{ USB_DEVICE(0x13d3, 0x3608), .driver_info = BTUSB_MEDIATEK |
> > + BTUSB_WIDEBAND_SPE
> > ECH },
> >
> > /* Additional Realtek 8723AE Bluetooth devices */
> > { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
>
> ************* MEDIATEK Confidentiality Notice ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!
Powered by blists - more mailing lists