linux-kernel - Re: [PATCH v16 09/16] x86/sgx: Add basic EPC reclamation flow for cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.2svz3rfywjvjmi@hhuan26-mobl.amr.corp.intel.com>
Date: Wed, 21 Aug 2024 23:00:53 -0500
From: "Haitao Huang" <haitao.huang@...ux.intel.com>
To: jarkko@...nel.org, dave.hansen@...ux.intel.com, kai.huang@...el.com,
 tj@...nel.org, mkoutny@...e.com, chenridong@...wei.com,
 linux-kernel@...r.kernel.org, linux-sgx@...r.kernel.org, x86@...nel.org,
 cgroups@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 hpa@...or.com, sohil.mehta@...el.com, tim.c.chen@...ux.intel.com, "Haitao
 Huang" <haitao.huang@...ux.intel.com>
Cc: zhiquan1.li@...el.com, kristen@...ux.intel.com, seanjc@...gle.com,
 zhanb@...rosoft.com, anakrish@...rosoft.com, mikko.ylinen@...ux.intel.com,
 yangjie@...rosoft.com, chrisyan@...rosoft.com
Subject: Re: [PATCH v16 09/16] x86/sgx: Add basic EPC reclamation flow for
 cgroup

> +static struct sgx_cgroup *sgx_cgroup_next_descendant_pre(struct  
> sgx_cgroup *root,
> +							 struct sgx_cgroup *cg)
> +{
> +	struct cgroup_subsys_state *next;
> +
> +	rcu_read_lock();
> +	for (;;) {
> +		next = css_next_descendant_pre(&cg->cg->css, &root->cg->css);

I  messed it up in a last minute change and rebase. Above should be:

+	struct cgroup_subsys_state *next = &cg->cg->css;
+
+	rcu_read_lock();
+	for (;;) {
+		next = css_next_descendant_pre(next, &root->cg->css);

Fixed in a branch here:  
https://github.com/haitaohuang/linux/tree/sgx_cg_upstream_v16_plus
Will include in next version or update if needed.

> +		if (!next) {
> +			next = &root->cg->css;
> +			break;
> +		}
> +
> +		if (css_tryget(next))
> +			break;
> +	}
> +	rcu_read_unlock();
> +
> +	return sgx_cgroup_from_misc_cg(css_misc(next));
> +}
> +
BR
Haitao