[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2024082210-stadium-sly-cf06@gregkh>
Date: Thu, 22 Aug 2024 12:27:26 +0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Lei Liu <liulei.rjpt@...o.com>
Cc: Neal Liu <neal_liu@...eedtech.com>, Joel Stanley <joel@....id.au>,
Andrew Jeffery <andrew@...econstruct.com.au>,
Daniel Mack <daniel@...que.org>,
Haojian Zhuang <haojian.zhuang@...il.com>,
Robert Jarzmik <robert.jarzmik@...e.fr>,
Conor Dooley <conor.dooley@...rochip.com>,
Daire McNamara <daire.mcnamara@...rochip.com>,
Bin Liu <b-liu@...com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
linux-aspeed@...ts.ozlabs.org, linux-usb@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers
On Thu, Aug 22, 2024 at 12:07:25PM +0800, Lei Liu wrote:
> The devm_clk_get_enabled() helpers:
> - call devm_clk_get()
> - call clk_prepare_enable() and register what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids calls to clk_disable_unprepare().
>
> ---
> The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of
> certain interfaces due to the lack of synchronization during the
> commit updates. These issues have been corrected in the v1 version.
>
> version 1 changes
> 1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to
> devm_clk_get_enabled().
> 2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to
> devm_clk_get_enabled().
> 3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be
> corrected to devm_clk_get_enabled().
Patch versions start at 1, this should be 2, right?
Powered by blists - more mailing lists