linux-kernel - Re: [PATCH 2/3] selftests/resctrl: Always initialize ecx to avoid build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3f1c35f-093a-4038-9ae9-540bfb58feef@collabora.com>
Date: Thu, 22 Aug 2024 09:49:05 +0500
From: Muhammad Usama Anjum <Usama.Anjum@...labora.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Shuah Khan <shuah@...nel.org>, Reinette Chatre <reinette.chatre@...el.com>,
 linux-kselftest@...r.kernel.org
Cc: Usama.Anjum@...labora.com, linux-kernel@...r.kernel.org,
 Shaopeng Tan <tan.shaopeng@...fujitsu.com>, Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH 2/3] selftests/resctrl: Always initialize ecx to avoid
 build warnings

On 8/13/24 3:45 PM, Ilpo Järvinen wrote:
> To avoid warnings when __cpuid_count() is an empty stub, always
> initialize ecx because it is used in the return statement.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/resctrl/cat_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
> index 51a1cb6aac34..9882c5d19408 100644
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -290,7 +290,7 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param
>  
>  static bool arch_supports_noncont_cat(const struct resctrl_test *test)
>  {
> -	unsigned int eax, ebx, ecx, edx;
> +	unsigned int eax, ebx, ecx = 0, edx;
>  
>  	switch (get_vendor()) {
>  	case ARCH_AMD:

-- 
BR,
Muhammad Usama Anjum