linux-kernel - Re: [PATCH 0/3] selftests: Fix cpuid / vendor checking build issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f4d4d41-e59d-4574-99e7-4dba69929954@collabora.com>
Date: Thu, 22 Aug 2024 09:51:37 +0500
From: Muhammad Usama Anjum <Usama.Anjum@...labora.com>
To: Shuah Khan <skhan@...uxfoundation.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Shuah Khan <shuah@...nel.org>, Reinette Chatre <reinette.chatre@...el.com>,
 linux-kselftest@...r.kernel.org
Cc: Usama.Anjum@...labora.com, linux-kernel@...r.kernel.org,
 Shaopeng Tan <tan.shaopeng@...fujitsu.com>, Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH 0/3] selftests: Fix cpuid / vendor checking build issues

On 8/21/24 11:30 AM, Shuah Khan wrote:
> On 8/13/24 04:45, Ilpo Järvinen wrote:
>> First, generalize resctrl selftest non-contiguous CAT check to not
>> assume non-AMD vendor implies Intel. Second, improve kselftest common
>> parts and resctrl selftest such that the use of __cpuid_count() does
>> not lead into a build failure (happens at least on ARM).
>>
>> The last patch might still require some work on which symbol the
>> conditional in kselftest.h is implemented. I could not find any
>> pre-existing one that could be used. Perhaps somebody who's more
>> familiar with the kselftest build system has a better suggestion on
>> which symbol the logic should be based at?
>>
>> Ilpo Järvinen (3):
>>    selftests/resctrl: Generalize non-contiguous CAT check
>>    selftests/resctrl: Always initialize ecx to avoid build warnings
>>    [RFC] kselftest: Provide __cpuid_count() stub on non-x86 archs
>>
>>   tools/testing/selftests/kselftest.h        |  6 +++++
>>   tools/testing/selftests/lib.mk             |  4 ++++
>>   tools/testing/selftests/resctrl/cat_test.c | 28 +++++++++++++---------
>>   3 files changed, 27 insertions(+), 11 deletions(-)
>>
> 
> These changes look good to me. Can you send the RFC patch without the
> RFC tag
> for me to pull in? I don't apply RFC patches.
> 
> Usama, does this fix the problem you are seeing?
Yeah, build errors are resolved.

> 
> Hi Reinette - do these look okay to you? Can you give me an ack if they do?
> 
> thanks,
> -- Shuah
> 
-- 
BR,
Muhammad Usama Anjum