linux-kernel - [PATCH] Prevent entering an infinite loop when i is 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240822062749.4012080-1-jinbaoliu365@gmail.com>
Date: Thu, 22 Aug 2024 14:27:49 +0800
From: liujinbao1 <jinbaoliu365@...il.com>
To: xiang@...nel.org
Cc: chao@...nel.org,
	linux-erofs@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org,
	liujinbao1 <liujinbao1@...omi.com>
Subject: [PATCH] Prevent entering an infinite loop when i is 0

From: liujinbao1 <liujinbao1@...omi.com>

When i=0 and err is not equal to 0,
the while(-1) loop will enter into an
infinite loop. This patch avoids this issue.
---
 fs/erofs/decompressor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/erofs/decompressor.c b/fs/erofs/decompressor.c
index c2253b6a5416..1b2b8cc7911c 100644
--- a/fs/erofs/decompressor.c
+++ b/fs/erofs/decompressor.c
@@ -539,6 +539,8 @@ int __init z_erofs_init_decompressor(void)
 	for (i = 0; i < Z_EROFS_COMPRESSION_MAX; ++i) {
 		err = z_erofs_decomp[i] ? z_erofs_decomp[i]->init() : 0;
 		if (err) {
+			if (!i)
+				return err;
 			while (--i)
 				if (z_erofs_decomp[i])
 					z_erofs_decomp[i]->exit();
-- 
2.25.1