linux-kernel - Re: [PATCH 1/8] smb/server: fix return value of smb2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd8iUmE9GmaSc=5dw4bT0prbNai0uW+QRc6YgnSuf0dtWA@mail.gmail.com>
Date: Thu, 22 Aug 2024 09:49:28 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: chenxiaosong@...nxiaosong.com
Cc: sfrench@...ba.org, senozhatsky@...omium.org, tom@...pey.com, 
	linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org, pc@...guebit.com, 
	ronniesahlberg@...il.com, sprasad@...rosoft.com, bharathsm@...rosoft.com, 
	chenxiaosong@...inos.cn, liuzhengyuan@...inos.cn, huhai@...inos.cn, 
	liuyun01@...inos.cn
Subject: Re: [PATCH 1/8] smb/server: fix return value of smb2_open()

On Tue, Aug 20, 2024 at 11:35 PM <chenxiaosong@...nxiaosong.com> wrote:
>
> From: ChenXiaoSong <chenxiaosong@...inos.cn>
>
> In most error cases, error code is not returned in smb2_open(),
> __process_request() will not print error message.
>
> Fix this by returning the correct value at the end of smb2_open().
>
> Signed-off-by: ChenXiaoSong <chenxiaosong@...nxiaosong.com>
Looks good to me.
Acked-by: Namjae Jeon <linkinjeon@...nel.org>
Thanks!