linux-kernel - Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALTg27kBYb5+GOwBz4a1-xeM-21DrbUh7eQyNkW9K_m6TdSwNQ@mail.gmail.com>
Date: Thu, 22 Aug 2024 02:03:22 +0100
From: Stuart <stuart.a.hayhurst@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linux-input@...r.kernel.org, Jiri Kosina <jikos@...nel.org>, 
	Benjamin Tissoires <bentiss@...nel.org>, linux-kernel@...r.kernel.org, 
	Markus Elfring <Markus.Elfring@....de>
Subject: Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver

> Maybe is_wired could be close to other bools below, to improve avoid
> holes in the structure?

Possibly, I put `name`, `is_wired` and `sidetone_max` together, since
they only depend on the device model and are set once.

> Missing newline.

Done

> I'm not familiar with the hid_hw_raw_request() API, but I think that a
> kfree(send_buf) is missing here.

The `__free(kfree)` on the declaration should take care of that

> Nitpick: No need to init.

Thanks, but that `ret` won't be in the next revision anyway

> You could save 2 lines if ret was initialized when declared.

Could I? Wouldn't it get overwritten by `hid_hw_raw_request`?

> devm_kasprintf() would simplify this.

Well that's a lot simpler...

Thanks,
Stuart