linux-kernel - Re: [PATCH] Staging: rtl8192e: Fix parenthesis alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024082253-duration-esteemed-a057@gregkh>
Date: Thu, 22 Aug 2024 15:49:28 +0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Gabriel Maciel Raad <ffunctor@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH] Staging: rtl8192e: Fix parenthesis alignment

On Wed, Aug 21, 2024 at 09:23:43PM -0300, Gabriel Maciel Raad wrote:
> Fix parenthesis alignment and unnecessary blank line in
> rtl92e_leisure_ps_enter to fix the following checkpatch.pl warnings:
> 
> CHECK: Alignment should match open parenthesis
> CHECK: Blank lines aren't necessary after an open brace '{'

You did two different things here (and one was not mentioned in the
subject line.)

Always do one "logical thing" per patch, this should be split up into 2
different onces.

thanks,

greg k-h