linux-kernel - Re: [PATCH] staging: rtl8192e: Fix indentation in r8192E

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024082226-yin-tug-eca5@gregkh>
Date: Thu, 22 Aug 2024 15:50:54 +0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: "Renan M. S. Florencio" <renanm.florencio@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH] staging: rtl8192e: Fix indentation in r8192E_dev.c

On Wed, Aug 21, 2024 at 09:25:26PM -0300, Renan M. S. Florencio wrote:
> Fix indentation in r8192E_dev.c to silence checkpatch warnings:
> 
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Renan M. S. Florencio <renanm.florencio@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b3d4b3394284..ec867801bfbd 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1741,7 +1741,7 @@ void rtl92e_update_ratr_table(struct net_device *dev)
>  	    ieee->ht_info->cur_short_gi_40mhz)
>  		ratr_value |= 0x80000000;
>  	else if (!ieee->ht_info->cur_tx_bw40mhz &&
> -		  ieee->ht_info->cur_short_gi_20mhz)
> +			ieee->ht_info->cur_short_gi_20mhz)

But the alignment does not now match, are you sure you ran your change
through checkpatch to verify it did what you thought it did?

thanks,

greg k-h