linux-kernel - Re: [PATCH v3 1/1] dt-bindings: leds: convert leds-lm3692x to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240822-reacquire-unseemly-bc651d79993c@spud>
Date: Thu, 22 Aug 2024 10:00:36 +0100
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Dan Murphy <dmurphy@...com>,
	"open list:LED SUBSYSTEM" <linux-leds@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: leds: convert leds-lm3692x to yaml
 format

On Wed, Aug 21, 2024 at 06:20:00PM -0400, Frank Li wrote:
> diff --git a/Documentation/devicetree/bindings/leds/ti.lm36922.yaml b/Documentation/devicetree/bindings/leds/ti.lm36922.yaml
> new file mode 100644
> index 0000000000000..8ffbc6b785a3e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/ti.lm36922.yaml
> @@ -0,0 +1,110 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/ti.lm36922.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments - LM3692x Highly Efficient White LED Driver
> +
> +maintainers:
> +  - Dan Murphy <dmurphy@...com>
> +
> +description: |
> +  The LM3692x is an ultra-compact, highly efficient,
> +  white-LED driver designed for LCD display backlighting.
> +
> +  The main difference between the LM36922 and LM36923 is the number of
> +  LED strings it supports. The LM36922 supports two strings while the LM36923
> +  supports three strings.
> +
> +  For more product information please see the link below:
> +  https://www.ti.com/lit/ds/snvsa29/snvsa29.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,lm36922
> +      - ti,lm36923
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +  enable-gpios:
> +    description: gpio pin to enable/disable the device.
> +
> +  vled-supply:
> +    description: LED supply
> +
> +  ti,ovp-microvolt:
> +    description: Overvoltage protection.
> +    default: 29000000
> +    enum: [17000000, 21000000, 25000000, 29000000]
> +
> +patternProperties:
> +  '^led@[0-3]$':
> +    type: object
> +    $ref: common.yaml
> +    properties:
> +      reg:
> +        enum: [0, 1, 2, 3]
> +        description: |
> +          0 - Will enable all LED sync paths
> +          1 - Will enable the LED1 sync
> +          2 - Will enable the LED2 sync
> +          3 - Will enable the LED3 sync (LM36923 only)
> +
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ti,lm36922
> +    then:
> +      properties:
> +        led@3: false

Provided that you tested my psuedo code
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)