linux-kernel - Re: [PATCH v1] drivers:ras:Fix the NULL vs IS_ERR() bug for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240822100507.00000566@Huawei.com>
Date: Thu, 22 Aug 2024 10:05:07 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Yang Ruibin <11162571@...o.com>
CC: Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>,
	<linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<opensource.kernel@...o.com>
Subject: Re: [PATCH v1] drivers:ras:Fix the NULL vs IS_ERR() bug for
 debugfs_create_dir()

On Wed, 21 Aug 2024 03:17:18 -0400
Yang Ruibin <11162571@...o.com> wrote:

> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.
> 
> Signed-off-by: Yang Ruibin <11162571@...o.com>
Ideally needs a fixes tag. 

Otherwise (given I looked into a similar one last night
with the same pattern).
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  drivers/ras/cec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
> index e440b15fbabc..ebd4631b685b 100644
> --- a/drivers/ras/cec.c
> +++ b/drivers/ras/cec.c
> @@ -489,7 +489,7 @@ static int __init create_debugfs_nodes(void)
>  	}
>  
>  	d = debugfs_create_dir("cec", dfs);
> -	if (!d) {
> +	if (IS_ERR(d)) {
>  		pr_warn("Error creating cec debugfs node!\n");
>  		return -1;
>  	}