linux-kernel - RE: [PATCH 1/2] i2c: emev2: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB113466D1AB122E210A12E3DFA868F2@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Thu, 22 Aug 2024 09:19:24 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Rong Qianfeng <rongqianfeng@...o.com>, Wolfram Sang
	<wsa+renesas@...g-engineering.com>, Andi Shyti <andi.shyti@...nel.org>, Paul
 Cercueil <paul@...pouillou.net>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>, "linux-i2c@...r.kernel.org"
	<linux-i2c@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mips@...r.kernel.org"
	<linux-mips@...r.kernel.org>
CC: "opensource.kernel@...o.com" <opensource.kernel@...o.com>
Subject: RE: [PATCH 1/2] i2c: emev2: Use devm_clk_get_enabled() helpers

Hi Rong Qianfeng,

Thanks for the patch.

> -----Original Message-----
> From: Rong Qianfeng <rongqianfeng@...o.com>
> Sent: Thursday, August 22, 2024 3:53 AM
> Subject: [PATCH 1/2] i2c: emev2: Use devm_clk_get_enabled() helpers
> 
> The devm_clk_get_enabled() helpers:    - call devm_clk_get()    - call clk_prepare_enable() and
> register what is needed in order to     call clk_disable_unprepare() when needed, as a managed
> resource.This simplifies the code and avoids the calls to clk_disable_unprepare().While at it, remove
> the goto label "err_clk:", and use its return value to return the error code.
> 
> Signed-off-by: Rong Qianfeng <rongqianfeng@...o.com>
> ---
>  drivers/i2c/busses/i2c-emev2.c | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c index
> 557409410445..20efe0b0cb85 100644
> --- a/drivers/i2c/busses/i2c-emev2.c
> +++ b/drivers/i2c/busses/i2c-emev2.c
> @@ -373,14 +373,10 @@ static int em_i2c_probe(struct platform_device *pdev)
> 
>  	strscpy(priv->adap.name, "EMEV2 I2C", sizeof(priv->adap.name));
> 
> -	priv->sclk = devm_clk_get(&pdev->dev, "sclk");
> +	priv->sclk = devm_clk_get_enabled(&pdev->dev, "sclk");

nit:
After your change sclk can be local. You can drop sclk from struct em_i2c_device
Maybe send another patch to fix this.

Cheers,
Biju

>  	if (IS_ERR(priv->sclk))
>  		return PTR_ERR(priv->sclk);
> 
> -	ret = clk_prepare_enable(priv->sclk);
> -	if (ret)
> -		return ret;
> -
>  	priv->adap.timeout = msecs_to_jiffies(100);
>  	priv->adap.retries = 5;
>  	priv->adap.dev.parent = &pdev->dev;
> @@ -397,26 +393,22 @@ static int em_i2c_probe(struct platform_device *pdev)
> 
>  	ret = platform_get_irq(pdev, 0);
>  	if (ret < 0)
> -		goto err_clk;
> +		return ret;
>  	priv->irq = ret;
>  	ret = devm_request_irq(&pdev->dev, priv->irq, em_i2c_irq_handler, 0,
>  				"em_i2c", priv);
>  	if (ret)
> -		goto err_clk;
> +		return ret;
> 
>  	ret = i2c_add_adapter(&priv->adap);
> 
>  	if (ret)
> -		goto err_clk;
> +		return ret;
> 
>  	dev_info(&pdev->dev, "Added i2c controller %d, irq %d\n", priv->adap.nr,
>  		 priv->irq);
> 
>  	return 0;
> -
> -err_clk:
> -	clk_disable_unprepare(priv->sclk);
> -	return ret;
>  }
> 
>  static void em_i2c_remove(struct platform_device *dev) @@ -424,7 +416,6 @@ static void
> em_i2c_remove(struct platform_device *dev)
>  	struct em_i2c_device *priv = platform_get_drvdata(dev);
> 
>  	i2c_del_adapter(&priv->adap);
> -	clk_disable_unprepare(priv->sclk);
>  }
> 
>  static const struct of_device_id em_i2c_ids[] = {
> --
> 2.39.0
>