linux-kernel - Re: [PATCH v1] drivers:block:Fix the NULL vs IS_ERR() bug for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3d2c9ca-7b46-4546-af87-9f9127c1e178@kernel.org>
Date: Thu, 22 Aug 2024 18:27:00 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Yang Ruibin <11162571@...o.com>, linux-block@...r.kernel.org,
 Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:block:Fix the NULL vs IS_ERR() bug for
 debugfs_create_dir()

On 8/21/24 15:49, Yang Ruibin wrote:
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.

...to check its return value.

And the patch title could be better. May be something like:

pktcdvd: Use IS_ERR() to check debugfs_create_dir() return value

> 
> Signed-off-by: Yang Ruibin <11162571@...o.com>

This needs a Fixes tag.

> ---
>  drivers/block/pktcdvd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
> index 7cece5884b9c..030b7a063a0b 100644
> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -498,7 +498,7 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
>  	if (!pkt_debugfs_root)
>  		return;
>  	pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root);
> -	if (!pd->dfs_d_root)
> +	if (IS_ERR(pd->dfs_d_root))
>  		return;
>  
>  	pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,

-- 
Damien Le Moal
Western Digital Research