linux-kernel - RE: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <PA4PR04MB96382C0635603A51371C0E23D18F2@PA4PR04MB9638.eurprd04.prod.outlook.com>
Date: Thu, 22 Aug 2024 09:36:29 +0000
From: David Lin <yu-hao.lin@....com>
To: Sascha Hauer <s.hauer@...gutronix.de>, Brian Norris
	<briannorris@...omium.org>, Francesco Dolcini <francesco@...cini.it>, Kalle
 Valo <kvalo@...nel.org>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention

> From: Sascha Hauer <s.hauer@...gutronix.de>
> Sent: Tuesday, August 20, 2024 7:56 PM
> To: Brian Norris <briannorris@...omium.org>; Francesco Dolcini
> <francesco@...cini.it>; Kalle Valo <kvalo@...nel.org>
> Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> kernel@...gutronix.de; Sascha Hauer <s.hauer@...gutronix.de>
> Subject: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention 
> 
> Align multiline if() under the opening brace.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> ---
>  drivers/net/wireless/marvell/mwifiex/wmm.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/wmm.c
> b/drivers/net/wireless/marvell/mwifiex/wmm.c
> index bcb61dab7dc86..1b1222c73728f 100644
> --- a/drivers/net/wireless/marvell/mwifiex/wmm.c
> +++ b/drivers/net/wireless/marvell/mwifiex/wmm.c
> @@ -1428,13 +1428,13 @@ mwifiex_dequeue_tx_packet(struct
> mwifiex_adapter *adapter)
>         }
> 
>         if (!ptr->is_11n_enabled ||
> -               ptr->ba_status ||
> -               priv->wps.session_enable) {
> +           ptr->ba_status ||
> +           priv->wps.session_enable) {
>                 if (ptr->is_11n_enabled &&
> -                       ptr->ba_status &&
> -                       ptr->amsdu_in_ampdu &&
> -                       mwifiex_is_amsdu_allowed(priv, tid) &&
> -                       mwifiex_is_11n_aggragation_possible(priv, ptr,
> +                   ptr->ba_status &&
> +                   ptr->amsdu_in_ampdu &&
> +                   mwifiex_is_amsdu_allowed(priv, tid) &&
> +                   mwifiex_is_11n_aggragation_possible(priv, ptr,
> 
> adapter->tx_buf_size))
>                         mwifiex_11n_aggregate_pkt(priv, ptr, ptr_index);
>                         /* ra_list_spinlock has been freed in
> 
> --
> 2.39.2
> 

I wonder we still need patch for indent issue here? If so I am sure we will need a bunch of similar patches which I don't think really help improve mwifiex quality

Actually in its successor Nxpwifi (currently under review), we have cleaned up all indent, and checkpatch errors/warnings/checks.

I would suggest for Mwifiex we only take real bug fixes (Odd fixes).

•WARNING: It's generally not useful to have the filename in the file
•WARNING: Possible unnecessary 'out of memory' message
•WARNING: space prohibited between function name and open parenthesis '(‘
•WARNING: Consecutive strings are generally better as a single string
•WARNING: unchecked sscanfreturn value
•WARNING: Single statement macros should not use a do {} while (0) loop
•WARNING: do {} while (0) macros should not be semicolon terminated
•WARNING: macros should not use a trailing semicolon
•ERROR: Use C99 flexible arrays - see https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays
•WARNING: Block comments use * on subsequent lines
•WARNING: const array should probably be static const
•WARNING: Prefer using '"%s...", __func__' to using 'mwifiex_register', this function's name, in a string
•WARNING: braces {} are not necessary for any arm of this statement
•WARNING: Prefer strscpyover strlcpy- see: https://github.com/KSPP/linux/issues/89
•WARNING: Statements should start on a tabstop
•WARNING: Prefer strscpyover strcpy- see: https://github.com/KSPP/linux/issues/88
•WARNING: Unnecessary space before function pointer arguments
•WARNING: Possible repeated word: 'send’
•WARNING: Possible repeated word: 'enabled’
•WARNING: quoted string split across lines
•WARNING: ENOSYS means 'invalid syscallnr' and nothing else
•WARNING:simple_strtolis obsolete, use kstrtolinstead
•ERROR: code indent should use tabs where possible
•WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
•CHECK: Avoid CamelCase: <HostCmd_CMD_ADD_NEW_STATION>
•WARNING: void function return statements are not generally useful
•WARNING: suspect code indent for conditional statements
•WARNING: braces {} are not necessary for single statement blocks
•WARNING: Avoid multiple line dereference
•WARNING: function definition argument ‘xxx' should also have an identifier name
•WARNING: else is not generally useful after a break or return
•WARNING: Missing a blank line after declarations
•WARNING: Block comments use a trailing */ on a separate line
•ERROR: need consistent spacing around '+’
•ERROR: open brace '{' following function definitions go on the next line
•WARNING: Comparisons should place the constant on the right side of the test

Thanks,
David