linux-kernel - Re: [PATCH v1] drivers:coresight:Use min macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be61331d-5ab0-4755-823b-f8420e8e79ee@vivo.com>
Date: Thu, 22 Aug 2024 17:41:42 +0800
From: Yang Ruibin <11162571@...o.com>
To: Suzuki K Poulose <suzuki.poulose@....com>,
 Mike Leach <mike.leach@...aro.org>, James Clark <james.clark@...aro.org>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:coresight:Use min macro

Sorry, please ignore this patch.
Because the corresponding header file is not included, there may be 
compilation errors.

在 2024/8/22 15:36, Yang Ruibin 写道:
> Instead of using the min() implementation of
> the ternary operator, use real macros.
>
> Signed-off-by: Yang Ruibin <11162571@...o.com>
> ---
>   drivers/hwtracing/coresight/coresight-catu.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c
> index bfea880d6..7ea67d56e 100644
> --- a/drivers/hwtracing/coresight/coresight-catu.c
> +++ b/drivers/hwtracing/coresight/coresight-catu.c
> @@ -152,8 +152,7 @@ static void catu_dump_table(struct tmc_sg_table *catu_table)
>   		catu_table, catu_table->table_daddr);
>   
>   	while (offset < buf_size) {
> -		table_end = offset + SZ_1M < buf_size ?
> -			    offset + SZ_1M : buf_size;
> +		table_end = min(offset + SZ_1M, buf_size);
>   		table = catu_get_table(catu_table, offset, NULL);
>   		for (i = 0; offset < table_end; i++, offset += CATU_PAGE_SIZE)
>   			dev_dbg(catu_table->dev, "%d: %llx\n", i, table[i]);