linux-kernel - Re: [PATCH v1] drivers:testing:Fix the NULL vs IS_ERR() bug for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h8std0JijjjTskTP2p1jubYQvsCmm30OVmNuj_S8QrqQ@mail.gmail.com>
Date: Thu, 22 Aug 2024 11:59:33 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Yang Ruibin <11162571@...o.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, 
	Lukasz Luba <lukasz.luba@....com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:testing:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()

On Thu, Aug 22, 2024 at 11:43 AM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> On Thu, Aug 22, 2024 at 4:59 AM Yang Ruibin <11162571@...o.com> wrote:
> >
> > The debugfs_create_dir() function returns error pointers.
> > It never returns NULL. So use IS_ERR() to check it.
> >
> > Signed-off-by: Yang Ruibin <11162571@...o.com>
> > ---
> >  drivers/thermal/testing/zone.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/testing/zone.c b/drivers/thermal/testing/zone.c
> > index fcee12b152da..26f0f80a6a5d 100644
> > --- a/drivers/thermal/testing/zone.c
> > +++ b/drivers/thermal/testing/zone.c
> > @@ -167,7 +167,7 @@ static void tt_add_tz_work_fn(struct work_struct *work)
> >
> >         snprintf(f_name, TT_MAX_FILE_NAME_LENGTH, "tz%d", tt_zone->id);
> >         tt_zone->d_tt_zone = debugfs_create_dir(f_name, d_testing);
> > -       if (!tt_zone->d_tt_zone) {
> > +       if (IS_ERR(tt_zone->d_tt_zone)) {
> >                 tt_zone_free(tt_zone);
> >                 return;
> >         }
> > --
>
> Thanks for catching this, but I'll just redo the patch while it is still fresh.

BTW, which tree is this patch against?

This issue has been addressed in my linux-next branch already AFAICS.