linux-kernel - Re: [PATCH v4] dt-bindings: hwmon: Add maxim max31790

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1ee66fa-e504-409f-97de-a923123f3d44@amperemail.onmicrosoft.com>
Date: Thu, 22 Aug 2024 17:20:43 +0700
From: Chanh Nguyen <chanh@...eremail.onmicrosoft.com>
To: Chanh Nguyen <chanh@...amperecomputing.com>,
 Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Justin Ledford
 <justinledford@...gle.com>, devicetree@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
 Open Source Submission <patches@...erecomputing.com>
Cc: Phong Vo <phong@...amperecomputing.com>,
 Thang Nguyen <thang@...amperecomputing.com>,
 Quan Nguyen <quan@...amperecomputing.com>,
 Khanh Pham <khpham@...erecomputing.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v4] dt-bindings: hwmon: Add maxim max31790

Hi all,

I only linked to patch v3: 
https://lore.kernel.org/lkml/20240813084152.25002-1-chanh@os.amperecomputing.com/T/#mce666b8184682e4d463d418a294d95512d95c07a 


Thanks,
Chanh

On 22/08/2024 15:48, Chanh Nguyen wrote:
> Add device tree bindings and an example for max31790 device.
> 
> Signed-off-by: Chanh Nguyen <chanh@...amperecomputing.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> Changes in v2:
>   - Update filename of the maxim,max31790.yaml                        [Krzysztof]
>   - Add the common fan schema to $ref                                 [Krzysztof]
>   - Update the node name to "fan-controller" in maxim,max31790.yaml   [Krzysztof]
>   - Drop "driver" in commit title                                     [Krzysztof]
> Changes in v3:
>   - Drop redundant "bindings" in commit title                         [Krzysztof]
>   - Add the clocks and resets property in example                     [Krzysztof]
>   - Add child node refer to fan-common.yaml                           [Krzysztof, Conor]
> Changes in v4:
>   - Add Chanh Nguyen to maintainers list                              [Chanh]
>   - Drop incomplete example                                           [Krzysztof, Conor]
>   - Drop the cover letter because only a patch existed                [Chanh]
> ---
>   .../bindings/hwmon/maxim,max31790.yaml        | 70 +++++++++++++++++++
>   1 file changed, 70 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> new file mode 100644
> index 000000000000..b1ff496f87f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: The Maxim MAX31790 Fan Controller
> +
> +maintainers:
> +  - Guenter Roeck <linux@...ck-us.net>
> +  - Chanh Nguyen <chanh@...amperecomputing.com>
> +
> +description: >
> +  The MAX31790 controls the speeds of up to six fans using six
> +  independent PWM outputs. The desired fan speeds (or PWM duty cycles)
> +  are written through the I2C interface.
> +
> +  Datasheets:
> +    https://datasheets.maximintegrated.com/en/ds/MAX31790.pdf
> +
> +properties:
> +  compatible:
> +    const: maxim,max31790
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  "#pwm-cells":
> +    const: 1
> +
> +patternProperties:
> +  "^fan-[0-9]+$":
> +    $ref: fan-common.yaml#
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      pwm_provider: fan-controller@20 {
> +        compatible = "maxim,max31790";
> +        reg = <0x20>;
> +        clocks = <&sys_clk>;
> +        resets = <&reset 0>;
> +        #pwm-cells = <1>;
> +
> +        fan-0 {
> +          pwms = <&pwm_provider 1>;
> +        };
> +
> +        fan-1 {
> +          pwms = <&pwm_provider 2>;
> +        };
> +      };
> +    };
> +