linux-kernel - Re: [PATCH v1 1/2] scsi: ufs: core: introduce override_cqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408221823.jnozM7Ys-lkp@intel.com>
Date: Thu, 22 Aug 2024 18:38:40 +0800
From: kernel test robot <lkp@...el.com>
To: Kiwoong Kim <kwmad.kim@...sung.com>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, alim.akhtar@...sung.com,
	avri.altman@....com, bvanassche@....org, jejb@...ux.ibm.com,
	martin.petersen@...cle.com, beanhuo@...ron.com,
	adrian.hunter@...el.com, h10.kim@...sung.com, hy50.seo@...sung.com,
	sh425.lee@...sung.com, kwangwon.min@...sung.com,
	junwoo80.lee@...sung.com, wkon.kim@...sung.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Kiwoong Kim <kwmad.kim@...sung.com>
Subject: Re: [PATCH v1 1/2] scsi: ufs: core: introduce override_cqe_ocs

Hi Kiwoong,

kernel test robot noticed the following build errors:

[auto build test ERROR on jejb-scsi/for-next]
[also build test ERROR on mkp-scsi/for-next krzk/for-next linus/master v6.11-rc4 next-20240822]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kiwoong-Kim/scsi-ufs-core-introduce-override_cqe_ocs/20240821-144404
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link:    https://lore.kernel.org/r/895b69ac1e938490cd1d17b5f82b6f730bcd82c2.1724222619.git.kwmad.kim%40samsung.com
patch subject: [PATCH v1 1/2] scsi: ufs: core: introduce override_cqe_ocs
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20240822/202408221823.jnozM7Ys-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240822/202408221823.jnozM7Ys-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408221823.jnozM7Ys-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/ufs/core/ufshcd.c:828:39: error: use of undeclared identifier 'hba'
     828 |                 return ufshcd_vops_override_cqe_ocs(hba,
         |                                                     ^
   drivers/ufs/core/ufshcd.c:10344:44: warning: shift count >= width of type [-Wshift-count-overflow]
    10344 |                 if (!dma_set_mask_and_coherent(hba->dev, DMA_BIT_MASK(64)))
          |                                                          ^~~~~~~~~~~~~~~~
   include/linux/dma-mapping.h:77:54: note: expanded from macro 'DMA_BIT_MASK'
      77 | #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
         |                                                      ^ ~~~
   1 warning and 1 error generated.


vim +/hba +828 drivers/ufs/core/ufshcd.c

   814	
   815	/**
   816	 * ufshcd_get_tr_ocs - Get the UTRD Overall Command Status
   817	 * @lrbp: pointer to local command reference block
   818	 * @cqe: pointer to the completion queue entry
   819	 *
   820	 * This function is used to get the OCS field from UTRD
   821	 *
   822	 * Return: the OCS field in the UTRD.
   823	 */
   824	static enum utp_ocs ufshcd_get_tr_ocs(struct ufshcd_lrb *lrbp,
   825					      struct cq_entry *cqe)
   826	{
   827		if (cqe)
 > 828			return ufshcd_vops_override_cqe_ocs(hba,
   829							    le32_to_cpu(cqe->status) &
   830							    MASK_OCS);
   831	
   832		return lrbp->utr_descriptor_ptr->header.ocs & MASK_OCS;
   833	}
   834	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki