linux-kernel - Re: [PATCH V3] clk: scmi: add is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZscYq5rFUKJiHR5y@bogus>
Date: Thu, 22 Aug 2024 11:53:31 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: cristian.marussi@....com, mturquette@...libre.com, sboyd@...nel.org,
	Sudeep Holla <sudeep.holla@....com>, linux-clk@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	arm-scmi@...r.kernel.org, d-gole@...com,
	Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V3] clk: scmi: add is_prepared hook

On Tue, Aug 06, 2024 at 10:56:01PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> Some clocks maybe default enabled by hardware. For clocks that don't
> have users, that will be left in hardware default state, because prepare
> count and enable count is zero,if there is no is_prepared hook to get
> the hardware state. So add is_prepared hook to detect the hardware
> state. Then when disabling the unused clocks, they can be simply
> turned OFF to save power during kernel boot.
>

LGTM,

Reviewed-by: Sudeep Holla <sudeep.holla@....com>

IIUC, there is no dependency on any SCMI changes, so this can go alone
via clk tree.

-- 
Regards,
Sudeep