linux-kernel - Re: [PATCH v2 02/12] smb/server: fix potential null-ptr-deref of lease_ctx_info in smb2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd_e3kpanj2-B-KneDbk_qPcy6Pte_kKHVeMx2-h-k+XhA@mail.gmail.com>
Date: Thu, 22 Aug 2024 20:48:48 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: chenxiaosong@...nxiaosong.com
Cc: sfrench@...ba.org, senozhatsky@...omium.org, tom@...pey.com, 
	linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org, pc@...guebit.com, 
	ronniesahlberg@...il.com, sprasad@...rosoft.com, bharathsm@...rosoft.com, 
	chenxiaosong@...inos.cn, liuzhengyuan@...inos.cn, huhai@...inos.cn, 
	liuyun01@...inos.cn
Subject: Re: [PATCH v2 02/12] smb/server: fix potential null-ptr-deref of
 lease_ctx_info in smb2_open()

On Thu, Aug 22, 2024 at 5:22 PM <chenxiaosong@...nxiaosong.com> wrote:
>
> From: ChenXiaoSong <chenxiaosong@...inos.cn>
>
> null-ptr-deref will occur when (req_op_level == SMB2_OPLOCK_LEVEL_LEASE)
> and parse_lease_state() return NULL.
>
> Fix this by check if 'lease_ctx_info' is NULL.
>
> Additionally, remove the redundant parentheses in
> parse_durable_handle_context().
>
> Signed-off-by: ChenXiaoSong <chenxiaosong@...inos.cn>
Applied it to #ksmbd-for-next-next.
Thanks.