linux-kernel - Re: [PATCH v1] driver:net:et131x:Remove NULL check of list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240822120718.GN2164@kernel.org>
Date: Thu, 22 Aug 2024 13:07:18 +0100
From: Simon Horman <horms@...nel.org>
To: Yuesong Li <liyuesong@...o.com>
Cc: mark.einon@...il.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] driver:net:et131x:Remove NULL check of list_entry()

On Thu, Aug 22, 2024 at 11:05:35AM +0800, Yuesong Li wrote:
> list_entry() will never return a NULL pointer, thus remove the
> check.
> 
> Signed-off-by: Yuesong Li <liyuesong@...o.com>

Hi Yuesong Li,

Thanks for your patch.

Some minor points about process.

1. As a Networking patch, that is not a bug fix, it should
   be explicitly targeted at net-next.

   Subject: [PATCH net-next] ...

2. Looking at git history, it looks like 'et131x' would be an appropriate
   prefix for this patch.

   Subject: [PATCH net-next] et131x: ...

Please consider reading
https://docs.kernel.org/process/maintainer-netdev.html

And, please post a v2, addressing the above, and including Mark's tag,
after waiting 24h from the initial patch posting (as described in the link
above). Please do so as a new email thread.

FWIIW, the code change itself looks good to me.

...

-- 
pw-bot: changes-requested