linux-kernel - Re: [PATCH v3 1/3] ethernet: stmmac: dwmac-rk: Fix typo for RK3588 code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2564871.TLnPLrj5Ze@diego>
Date: Fri, 23 Aug 2024 16:21:25 +0200
From: Heiko Stübner <heiko@...ech.de>
To: linux-kernel@...r.kernel.org,
 Detlev Casanova <detlev.casanova@...labora.com>
Cc: "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 David Wu <david.wu@...k-chips.com>,
 Giuseppe Cavallaro <peppe.cavallaro@...com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com,
 kernel@...labora.com, Detlev Casanova <detlev.casanova@...labora.com>
Subject:
 Re: [PATCH v3 1/3] ethernet: stmmac: dwmac-rk: Fix typo for RK3588 code

Am Freitag, 23. August 2024, 16:11:13 CEST schrieb Detlev Casanova:
> Fix SELET -> SELECT in RK3588_GMAC_CLK_SELET_CRU and
> RK3588_GMAC_CLK_SELET_IO
> 
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> index 7ae04d8d291c8..9cf0aa58d13bf 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> @@ -1141,8 +1141,8 @@ static const struct rk_gmac_ops rk3568_ops = {
>  #define RK3588_GMAC_CLK_RMII_MODE(id)		GRF_BIT(5 * (id))
>  #define RK3588_GMAC_CLK_RGMII_MODE(id)		GRF_CLR_BIT(5 * (id))
>  
> -#define RK3588_GMAC_CLK_SELET_CRU(id)		GRF_BIT(5 * (id) + 4)
> -#define RK3588_GMAC_CLK_SELET_IO(id)		GRF_CLR_BIT(5 * (id) + 4)
> +#define RK3588_GMAC_CLK_SELECT_CRU(id)		GRF_BIT(5 * (id) + 4)
> +#define RK3588_GMAC_CLK_SELECT_IO(id)		GRF_CLR_BIT(5 * (id) + 4)
>  
>  #define RK3588_GMA_CLK_RMII_DIV2(id)		GRF_BIT(5 * (id) + 2)
>  #define RK3588_GMA_CLK_RMII_DIV20(id)		GRF_CLR_BIT(5 * (id) + 2)
> @@ -1240,8 +1240,8 @@ static void rk3588_set_gmac_speed(struct rk_priv_data *bsp_priv, int speed)
>  static void rk3588_set_clock_selection(struct rk_priv_data *bsp_priv, bool input,
>  				       bool enable)
>  {
> -	unsigned int val = input ? RK3588_GMAC_CLK_SELET_IO(bsp_priv->id) :
> -				   RK3588_GMAC_CLK_SELET_CRU(bsp_priv->id);
> +	unsigned int val = input ? RK3588_GMAC_CLK_SELECT_IO(bsp_priv->id) :
> +				   RK3588_GMAC_CLK_SELECT_CRU(bsp_priv->id);
>  
>  	val |= enable ? RK3588_GMAC_CLK_RMII_NOGATE(bsp_priv->id) :
>  			RK3588_GMAC_CLK_RMII_GATE(bsp_priv->id);
>