linux-kernel - Re: [PATCH net-next v3 2/8] selftests/net: Provide test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJwJo6YFqhS6KS2fArzg8ovDbWgysDvwvB8KmO-gJoPdWOBw9w@mail.gmail.com>
Date: Fri, 23 Aug 2024 15:27:17 +0100
From: Dmitry Safonov <0x7f454c46@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, 
	Mohammad Nassiri <mnassiri@...na.com>, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/8] selftests/net: Provide test_snprintf() helper

On Thu, 22 Aug 2024 at 11:13, Simon Horman <horms@...nel.org> wrote:
>
> On Wed, Aug 21, 2024 at 10:35:10PM +0100, Dmitry Safonov wrote:
> > Hi Simon,
> >
> > On Wed, 21 Aug 2024 at 20:10, Simon Horman <horms@...nel.org> wrote:
> > >
[..]
> > > Hi Dmitry,
> > >
> > > Some minor nits, as it looks like there will be a v4.
> >
> > Thanks, both seem reasonable.
> > Did you get them with checkpatch.pl or with your trained eyes? :)
> >
> > These days I run b4 prep --check and on latest version it just gave a
> > bunch of fmt-strings with columns > 100.
>
> Hi Dimitry,
>
> For networking code I usually run:
>
> checkpatch.pl --strict --codespell --min-conf-desc-length=80
>
> Where 80 is, I believe, still in line with preferences for Networking code.
> Although I'm not entirely sure it is applicable to this patch.
>
> As to your question, in this case I think it is the --strict that causes
> checkpatch to flag the issues I raised. Sorry for not mentioning that in my
> previous email.

Good, thanks!
Now I can see/fix them :-)

Cheers,
             Dmitry