linux-kernel - Re: [PATCH v3 1/5] KVM: s390: selftests: Add regression tests for SORTL and DFLTCC CPU subfunctions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D3NDG2T6LAPQ.2NWIY72YYTM3F@linux.ibm.com>
Date: Fri, 23 Aug 2024 16:47:18 +0200
From: "Christoph Schlameuss" <schlameuss@...ux.ibm.com>
To: "Hariharan Mari" <hari55@...ux.ibm.com>, <linux-kselftest@...r.kernel.org>
Cc: <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>, <shuah@...nel.org>,
        <frankja@...ux.ibm.com>, <borntraeger@...ux.ibm.com>,
        <imbrenda@...ux.ibm.com>, <david@...hat.com>, <pbonzini@...hat.com>
Subject: Re: [PATCH v3 1/5] KVM: s390: selftests: Add regression tests for
 SORTL and DFLTCC CPU subfunctions

On Fri Aug 23, 2024 at 3:05 PM CEST, Hariharan Mari wrote:
> Introduce new regression tests to verify the ASM inline block in the SORTL
> and DFLTCC CPU subfunctions for the s390x architecture. These tests ensure
> that future changes to the ASM code are properly validated.
>
> The test procedure:
>
> 1. Create a VM and request the KVM_S390_VM_CPU_MACHINE_SUBFUNC attribute
>    from the KVM_S390_VM_CPU_MODEL group for this VM. This SUBFUNC attribute
>    contains the results of all CPU subfunction instructions.
> 2. For each tested subfunction (SORTL and DFLTCC), execute the
>    corresponding ASM instruction and capture the result array.
> 3. Perform a memory comparison between the results stored in the SUBFUNC
>    attribute (obtained in step 1) and the ASM instruction results (obtained
>    in step 2) for each tested subfunction.
>
> This process ensures that the KVM implementation accurately reflects the
> behavior of the actual CPU instructions for the tested subfunctions.
>
> Suggested-by: Janosch Frank <frankja@...ux.ibm.com>
> Signed-off-by: Hariharan Mari <hari55@...ux.ibm.com>
> Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>

LGTM

Reviewed-by: Christoph Schlameuss <schlameuss@...ux.ibm.com>

> ---
>  tools/testing/selftests/kvm/Makefile          |   2 +
>  .../selftests/kvm/include/s390x/facility.h    |  50 +++++++++
>  .../selftests/kvm/lib/s390x/facility.c        |  14 +++
>  .../kvm/s390x/cpumodel_subfuncs_test.c        | 105 ++++++++++++++++++
>  4 files changed, 171 insertions(+)
>  create mode 100644 tools/testing/selftests/kvm/include/s390x/facility.h
>  create mode 100644 tools/testing/selftests/kvm/lib/s390x/facility.c
>  create mode 100644 tools/testing/selftests/kvm/s390x/cpumodel_subfuncs_test.c

[...]