[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZsijtURSzEWKCqHk@smile.fi.intel.com>
Date: Fri, 23 Aug 2024 17:59:01 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Ye Zhang <ye.zhang@...k-chips.com>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, heiko@...ech.de,
linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
mika.westerberg@...ux.intel.com, tao.huang@...k-chips.com,
finley.xiao@...k-chips.com, tim.chen@...k-chips.com,
elaine.zhang@...k-chips.com
Subject: Re: [PATCH v2] gpio: rockchip: Set input direction when request irq
On Fri, Aug 23, 2024 at 11:43:12AM +0800, Ye Zhang wrote:
> Since the GPIO can only generate interrupts when its direction is set to
> input, it is set to input before requesting the interrupt resources.
...
> + rockchip_gpio_direction_input(&bank->gpio_chip, d->hwirq);
> +
> return gpiochip_reqres_irq(&bank->gpio_chip, d->hwirq);
In both cases you want to use irq_hw_number_t and irqd_to_hwirq() at the top of
the function(s).
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists