linux-kernel - Re: [PATCH 1/2] arm: mm: Fix kernel memory mapping for xip kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZBWDf2t=xY83JePUR34K4qS1QnVivLELp6W779rLZf=g@mail.gmail.com>
Date: Fri, 23 Aug 2024 17:36:49 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Harith George <mail2hgg@...il.com>
Cc: linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, harith.g@...fsemi.com, 
	akpm@...ux-foundation.org, rppt@...nel.org, rmk+kernel@...linux.org.uk, 
	m.szyprowski@...sung.com, vishal.moola@...il.com, david@...hat.com, 
	willy@...radead.org, nico@...xnic.net, ardb@...nel.org
Subject: Re: [PATCH 1/2] arm: mm: Fix kernel memory mapping for xip kernels

On Wed, Jul 31, 2024 at 1:39 PM Harith George <mail2hgg@...il.com> wrote:

> From: Harith George <harith.g@...fsemi.com>
>
> The patchset introducing kernel_sec_start/end variables to separate the
> kernel/lowmem memory mappings, broke the mapping of the kernel memory
> for xipkernels.
>
> kernel_sec_start/end variables are in RO area before the MMU is switched
> on for xipkernels.
> So these cannot be set early in boot in head.S. Fix this by setting these
> after MMU is switched on.
> xipkernels need two different mappings for kernel text (starting at
> CONFIG_XIP_PHYS_ADDR) and data (starting at CONFIG_PHYS_OFFSET).
> Also, move the kernel code mapping from devicemaps_init() to map_kernel().
>
> Fixes: a91da5457085 ("ARM: 9089/1: Define kernel physical section start and end")
> Signed-off-by: Harith George <harith.g@...fsemi.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
(also for patch 2/2)

Sorry for breaking XIP :(

Can you put these patches into Russell's patch tracker so he
can track it?
https://www.armlinux.org.uk/developer/patches/

Yours,
Linus Walleij