linux-kernel - Re: [PATCH 0/3] cpufreq/amd-pstate: A set of fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62bd38f8-1265-48ec-8ab5-b7e5a259eac1@amd.com>
Date: Fri, 23 Aug 2024 10:42:58 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: "Gautham R. Shenoy" <gautham.shenoy@....com>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Huang Rui <ray.huang@....com>,
 Perry Yuan <perry.yuan@....com>, Dan Carpenter <dan.carpenter@...aro.org>,
 Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>, David Wang <00107082@....com>
Subject: Re: [PATCH 0/3] cpufreq/amd-pstate: A set of fixes

On 8/22/2024 23:13, Gautham R. Shenoy wrote:
> Hello Mario,
> 
> 
> On Thu, Aug 22, 2024 at 03:41:30PM -0500, Mario Limonciello wrote:
>> On 8/13/2024 04:51, Gautham R. Shenoy wrote:
>>> Hello Rafael, Viresh,
>>>
>>> This series contains three fixes for the amd-pstate driver for 6.11.
>>> Could you please include it in your tree?
>>>
>>> These patches are based on linux-pm/master with the top commit
>>> 7c626ce4bae1 ("Linux 6.11-rc3").
>>>
>>> There are three patches,
>>>
>>> 1. To fix an uninitialized variable in amd_pstate_cpu_boost_update()
>>>      from Dan Carpenter:
>>>      https://lore.kernel.org/lkml/7ff53543-6c04-48a0-8d99-7dc010b93b3a@stanley.mountain/
>>>
>>> 2. Use topology_logical_package_id() instead of
>>>      topology_logical_die_id() definition of the later function has
>>>      changed on some AMD processors since the inclusion of the CPUID
>>>      0x80000026 parser:
>>>      https://lore.kernel.org/lkml/20240801124509.3650-1-Dhananjay.Ugwekar@amd.com/
>>>
>>> 3. Remove a warning for the absence fo X86_FEATURE_CPPC on Zen1 and
>>>      Zen2 since they don't have the feature defined. This fixes the
>>>      regression reported by David Wang:
>>>      https://lore.kernel.org/lkml/20240730140111.4491-1-00107082@163.com/
> 
>>>
>>> Thanks and Regards
>>> gautham.
>>>
>>> Dan Carpenter (1):
>>>     cpufreq: amd-pstate: Fix uninitialized variable in
>>>       amd_pstate_cpu_boost_update()
>>>
>>> Gautham R. Shenoy (2):
>>>     cpufreq/amd-pstate: Use topology_logical_package_id() instead of
>>>       logical_die_id()
>>>     cpufreq/amd-pstate: Remove warning for X86_FEATURE_CPPC on Zen1 and
>>>       Zen2
>>>
>>>    drivers/cpufreq/amd-pstate.c | 10 ++++------
>>>    1 file changed, 4 insertions(+), 6 deletions(-)
>>>
>>
>> Thanks for handling these.  I'm back now, I'm digging through my inbox.
>> Assuming Rafael didn't already pull these I'll batch these into my
>> amd-pstate branch for the robots to bang on and then send a PR after I go
>> through everything else that happened.
> 
> Thank you Mario. I will be sending an updated version to Patch 3
> "Remove warning for X86_FEATURE_CPPC on Zen1 and Zen2" to incorporate
> feedback from Xiaojian.
> 
> Please merge the Patches 1 and 2 from this series.
> 

Thanks, they're staged with the other fixes that were on the list.
Will wait for your updated patch 3 for the fixes PR.