linux-kernel - Re: [PATCH v2 0/3] perf: Add PERF_EVENT_IOC_INC_EVENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsgEqrR6eux9kFcx@ghost>
Date: Thu, 22 Aug 2024 20:40:26 -0700
From: Charlie Jenkins <charlie@...osinc.com>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Atish Patra <atishp@...osinc.com>
Cc: linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Shunsuke Nakamura <nakamura.shun@...itsu.com>
Subject: Re: [PATCH v2 0/3] perf: Add PERF_EVENT_IOC_INC_EVENT_LIMIT

On Wed, Aug 07, 2024 at 05:02:39PM -0700, Charlie Jenkins wrote:
> Introduce a new perf ioctl key PERF_EVENT_IOC_INC_EVENT_LIMIT that
> functions the same as PERF_EVENT_IOC_REFRESH, except it does not
> immediately enable counters.
> 
> Also create a libperf API perf_evsel__refresh() to allow libperf users
> access to this ioctl key.
> 
> Signed-off-by: Charlie Jenkins <charlie@...osinc.com>
> ---
> Changes in v2:
> - Drop discussion about signal race condition
> - Add new patch "libperf: Add perf_evsel__refresh() function"
> - This newly added patch was pulled from a different series with
>   modifications to fit the new ioctl key
> -
> https://lore.kernel.org/lkml/20240726-overflow_check_libperf-v2-0-7d154dcf6bea@rivosinc.com/
> will be updated
> - Link to v1: https://lore.kernel.org/r/20240724-perf_set_event_limit-v1-0-e680c93eca55@rivosinc.com
> 
> ---
> Charlie Jenkins (3):
>       perf: Add PERF_EVENT_IOC_INC_EVENT_LIMIT
>       perf: Document PERF_EVENT_IOC_INC_EVENT_LIMIT
>       libperf: Add perf_evsel__refresh() function
> 
>  include/linux/perf_event.h               |  4 +--
>  include/uapi/linux/perf_event.h          |  1 +
>  kernel/events/core.c                     | 17 +++++++----
>  tools/include/uapi/linux/perf_event.h    |  1 +
>  tools/lib/perf/Documentation/libperf.txt |  2 ++
>  tools/lib/perf/evsel.c                   | 49 ++++++++++++++++++++++++++------
>  tools/lib/perf/include/perf/evsel.h      |  2 ++
>  tools/lib/perf/libperf.map               |  2 ++
>  tools/perf/design.txt                    |  5 ++++
>  9 files changed, 67 insertions(+), 16 deletions(-)
> ---
> base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd
> change-id: 20240724-perf_set_event_limit-079f1b996376
> -- 
> - Charlie
> 

I am interested in people's opinion of this. Let me know if there are
any concerns.

- Charlie