linux-kernel - Re: [PATCH v2 1/1] mtd: slram: insert break after errors in parsing the map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240823173329.441853-1-miquel.raynal@bootlin.com>
Date: Fri, 23 Aug 2024 19:33:29 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Mirsad Todorovac <mtodorovac69@...il.com>,
	linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Cc: Miquel Raynal <miquel.raynal@...tlin.com>,
	Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v2 1/1] mtd: slram: insert break after errors in parsing the map

On Thu, 2024-07-11 at 23:43:20 UTC, Mirsad Todorovac wrote:
> GCC 12.3.0 compiler on linux-next next-20240709 tree found the execution
> path in which, due to lazy evaluation, devlength isn't initialised with the
> parsed string:
> 
>    289		while (map) {
>    290			devname = devstart = devlength = NULL;
>    291
>    292			if (!(devname = strsep(&map, ","))) {
>    293				E("slram: No devicename specified.\n");
>    294				break;
>    295			}
>    296			T("slram: devname = %s\n", devname);
>    297			if ((!map) || (!(devstart = strsep(&map, ",")))) {
>    298				E("slram: No devicestart specified.\n");
>    299			}
>    300			T("slram: devstart = %s\n", devstart);
>  → 301			if ((!map) || (!(devlength = strsep(&map, ",")))) {
>    302				E("slram: No devicelength / -end specified.\n");
>    303			}
>  → 304			T("slram: devlength = %s\n", devlength);
>    305			if (parse_cmdline(devname, devstart, devlength) != 0) {
>    306				return(-EINVAL);
>    307			}
> 
> Parsing should be finished after map == NULL, so a break is best inserted after
> each E("slram: ... \n") error message.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: Miquel Raynal <miquel.raynal@...tlin.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Vignesh Raghavendra <vigneshr@...com>
> Cc: linux-mtd@...ts.infradead.org
> Signed-off-by: Mirsad Todorovac <mtodorovac69@...il.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel