linux-kernel - Re: [PATCH v3 02/11] i3c: master: Replace hard code 2 with macro I3C_ADDR_SLOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsjNi4RQ+GKxZpUH@lizhi-Precision-Tower-5810>
Date: Fri, 23 Aug 2024 13:57:31 -0400
From: Frank Li <Frank.li@....com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Boris Brezillon <boris.brezillon@...labora.com>,
	Parshuram Thombare <pthombar@...ence.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Boris Brezillon <bbrezillon@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Conor Culhane <conor.culhane@...vaco.com>,
	linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev
Subject: Re: [PATCH v3 02/11] i3c: master: Replace hard code 2 with macro
 I3C_ADDR_SLOT_BITS

On Fri, Aug 23, 2024 at 05:55:02PM +0200, Miquel Raynal wrote:
> Hi Frank,
>
> Frank.Li@....com wrote on Mon, 19 Aug 2024 12:01:56 -0400:
>
> > Replace the hardcoded value 2, which indicates 2 bits for I3C address
> > status, with the predefined macro I3C_ADDR_SLOT_BITS.
>
> I'm fine with the idea but I don't understand the macro name. You're
> talking about status bits and yet the macro is named addr_slot?
>

How about I3C_ADDR_SLOT_STATUS_BITS ?

> > Improve maintainability and extensibility of the code.
>
> Thanks,
> Miquèl