linux-kernel - Re: [PATCH 6/7] staging: vchiq_core: Remove unused function argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <437e7171-097d-43b0-876e-c6343518197d@gmx.net>
Date: Fri, 23 Aug 2024 23:47:15 +0200
From: Stefan Wahren <wahrenst@....net>
To: Umang Jain <umang.jain@...asonboard.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, Dan Carpenter <dan.carpenter@...aro.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Arnd Bergmann <arnd@...db.de>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Phil Elwell <phil@...pberrypi.com>
Subject: Re: [PATCH 6/7] staging: vchiq_core: Remove unused function argument

Am 23.08.24 um 17:14 schrieb Umang Jain:
> The argument 'is_blocking' in queue_message_sync() is not
> used in the function. Drop it.
>
> Signed-off-by: Umang Jain <umang.jain@...asonboard.com>
Good catch!

Reviewed-by: Stefan Wahren <wahrenst@....net>
> ---
>   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index 43c6a214be86..84631878f77d 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -1146,7 +1146,7 @@ queue_message_sync(struct vchiq_state *state, struct vchiq_service *service,
>   		   int msgid,
>   		   ssize_t (*copy_callback)(void *context, void *dest,
>   					    size_t offset, size_t maxsize),
> -		   void *context, int size, int is_blocking)
> +		   void *context, int size)
>   {
>   	struct vchiq_shared_state *local;
>   	struct vchiq_header *header;
> @@ -1524,7 +1524,7 @@ parse_open(struct vchiq_state *state, struct vchiq_header *header)
>   		/* Acknowledge the OPEN */
>   		if (service->sync) {
>   			if (queue_message_sync(state, NULL, openack_id, memcpy_copy_callback,
> -					       &ack_payload, sizeof(ack_payload), 0) == -EAGAIN)
> +					       &ack_payload, sizeof(ack_payload)) == -EAGAIN)
>   				goto bail_not_ready;
>
>   			/* The service is now open */
> @@ -3150,7 +3150,7 @@ vchiq_queue_message(struct vchiq_instance *instance, unsigned int handle,
>   		break;
>   	case VCHIQ_SRVSTATE_OPENSYNC:
>   		status = queue_message_sync(service->state, service, data_id,
> -					    copy_callback, context, size, 1);
> +					    copy_callback, context, size);
>   		break;
>   	default:
>   		status = -EINVAL;
>