linux-kernel - Re: [PATCH] KVM: x86/mmu: Check that root is valid/loaded when pre-faulting SPTEs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172442177547.3955389.11987354449064860269.b4-ty@google.com>
Date: Fri, 23 Aug 2024 16:47:41 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	syzbot+23786faffb695f17edaa@...kaller.appspotmail.com
Subject: Re: [PATCH] KVM: x86/mmu: Check that root is valid/loaded when
 pre-faulting SPTEs

On Mon, 22 Jul 2024 17:02:11 -0700, Sean Christopherson wrote:
> Error out if kvm_mmu_reload() fails when pre-faulting memory, as trying to
> fault-in SPTEs will fail miserably due to root.hpa pointing at garbage.
> 
> Note, kvm_mmu_reload() can return -EIO and thus trigger the WARN on -EIO
> in kvm_vcpu_pre_fault_memory(), but all such paths also WARN, i.e. the
> WARN isn't user-triggerable and won't run afoul of warn-on-panic because
> the kernel would already be panicking.
> 
> [...]

Applied to kvm-x86 fixes, thanks!

[1/1] KVM: x86/mmu: Check that root is valid/loaded when pre-faulting SPTEs
      https://github.com/kvm-x86/linux/commit/28cec7f08b8b

--
https://github.com/kvm-x86/linux/tree/next