[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <172443896940.4129936.14195284777076363677.b4-ty@google.com>
Date: Fri, 23 Aug 2024 16:47:53 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
David Matlack <dmatlack@...gle.com>
Subject: Re: [PATCH v2] KVM: x86/mmu: Clean up function comments for dirty
logging APIs
On Fri, 02 Aug 2024 13:20:06 -0700, Sean Christopherson wrote:
> Rework the function comment for kvm_arch_mmu_enable_log_dirty_pt_masked()
> into the body of the function, as it has gotten a bit stale, is harder to
> read without the code context, and is the last source of warnings for W=1
> builds in KVM x86 due to using a kernel-doc comment without documenting
> all parameters.
>
> Opportunistically subsume the functions comments for
> kvm_mmu_write_protect_pt_masked() and kvm_mmu_clear_dirty_pt_masked(), as
> there is no value in regurgitating similar information at a higher level,
> and capturing the differences between write-protection and PML-based dirty
> logging is best done in a common location.
>
> [...]
Applied to kvm-x86 mmu, thanks!
[1/1] KVM: x86/mmu: Clean up function comments for dirty logging APIs
https://github.com/kvm-x86/linux/commit/acf2923271ef
--
https://github.com/kvm-x86/linux/tree/next
Powered by blists - more mailing lists