[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2024082315-capably-broiler-b4e6@gregkh>
Date: Fri, 23 Aug 2024 08:14:08 +0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
linux-kernel@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>,
stable@...r.kernel.org
Subject: Re: [PATCH] driver core: Fix an uninitialized variable is used by
__device_attach()
On Fri, Aug 23, 2024 at 07:46:09AM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
>
> An uninitialized variable @data.have_async may be used as analyzed
> by the following inline comments:
>
> static int __device_attach(struct device *dev, bool allow_async)
> {
> // if @allow_async is true.
>
> ...
> struct device_attach_data data = {
> .dev = dev,
> .check_async = allow_async,
> .want_async = false,
> };
> // @data.have_async is not initialized.
As Dmitry said, this is incorrect, please fix your broken code analysis
tool, it is obviously not working properly :(
thanks,
greg k-h
Powered by blists - more mailing lists