linux-kernel - RE: [PATCH] PCI: hotplug: Add OCTEON PCI hotplug controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR18MB44258270BCAF802C8B3398B5D9882@PH0PR18MB4425.namprd18.prod.outlook.com>
Date: Fri, 23 Aug 2024 05:29:46 +0000
From: Shijith Thotton <sthotton@...vell.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
CC: "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Jerin Jacob <jerinj@...vell.com>,
        Srujana
 Challa <schalla@...vell.com>,
        Vamsi Krishna Attunuru <vattunuru@...vell.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        D Scott Phillips
	<scott@...amperecomputing.com>,
        Philipp Stanner <pstanner@...hat.com>
Subject: RE: [PATCH] PCI: hotplug: Add OCTEON PCI hotplug controller driver

>>> This patch introduces a PCI hotplug controller driver for the OCTEON
>>> PCIe device, a multi-function PCIe device where the first function acts
>>> as a hotplug controller. It is equipped with MSI-x interrupts to notify
>>> the host of hotplug events from the OCTEON firmware.
>>>
>>> The driver facilitates the hotplugging of non-controller functions
>>> within the same device. During probe, non-controller functions are
>>> removed and registered as PCI hotplug slots. The slots are added back
>>> only upon request from the device firmware. The driver also allows the
>>> enabling and disabling of the slots via sysfs slot entries, provided by
>>> the PCI hotplug framework.
>>>
>>> Signed-off-by: Shijith Thotton <sthotton@...vell.com>
>>> Signed-off-by: Vamsi Attunuru <vattunuru@...vell.com>
>>I was curious, so drive by review.
>>
>>What was Vamsi's involvement?  Given Shijith sent this
>>I'd guess co developer?  In which Co-developed-by tag
>>should be used.
>>
...
>>> +}
>>> +
>>> +static int octep_hp_controller_setup(struct pci_dev *pdev, struct
>>octep_hp_controller *hp_ctrl)
>>> +{
>>> +	struct device *dev = &pdev->dev;
>>> +	int ret;
>>> +
>>> +	ret = pcim_enable_device(pdev);
>>> +	if (ret) {
>>> +		dev_err(dev, "Failed to enable PCI device\n");
>>Only called from probe, so
>>		return dev_err_probe()
>>
>>> +		return ret;
>>> +	}
>>> +
>>> +	ret = pcim_iomap_regions(pdev, BIT(0), OCTEP_HP_DRV_NAME);
>>Given there is a patch on list deprecating this, reconsider.
>> https://lore.kernel.org/all/20240807083018.8734-2-
>pstanner@...hat.com/
>>+CC Philipp
>>
>
>Okay. The API is available in origin/devres branch.  Will rebase on top of it.
>

I forgot about the kernel test robot.
I'll hold off on making this change until the patch is merged into pci/next.