linux-kernel - Re: [PATCH -next RESEND] nvmet: Make nvmet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2ce9842-5361-423c-b281-812cb19fc2ed@nvidia.com>
Date: Fri, 23 Aug 2024 06:41:03 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>
CC: "hch@....de" <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>, Chaitanya
 Kulkarni <chaitanyak@...dia.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next RESEND] nvmet: Make nvmet_debugfs static

On 8/22/24 00:19, Jinjie Ruan wrote:
> The sparse tool complains as follows:
>
> drivers/nvme/target/debugfs.c:16:15: warning:
> 	symbol 'nvmet_debugfs' was not declared. Should it be static?
>
> This symbol is not used outside debugfs.c, so marks it static.
>
> Signed-off-by: Jinjie Ruan<ruanjinjie@...wei.com>

I had patch written for this didn't get a chance to send [1].

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck

 From 15fc2ed4d9508d8489ce99a8794f8cbf45f2b3d2 Mon Sep 17 00:00:00 2001
From: Chaitanya Kulkarni <kch@...dia.com>
Date: Mon, 24 Jun 2024 22:28:56 -0700
Subject: [PATCH] nvmet: mark nvmet_debugfs static

Mark struct dentry *nvmet_debugfs static in debugfs.c as it is only used
in debugfs.c to remove the following sparse warning reported by kernel
bot:-

drivers/nvme/target/debugfs.c:16:15: sparse: sparse: symbol 
'nvmet_debugfs' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@...el.com>
Closes: 
https://lore.kernel.org/oe-kbuild-all/202406200501.5DrFu8Fu-lkp@intel.com/
Signed-off-by: Chaitanya Kulkarni <kch@...dia.com>
---
  drivers/nvme/target/debugfs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/debugfs.c b/drivers/nvme/target/debugfs.c
index cb2befc8619e..220c7391fc19 100644
--- a/drivers/nvme/target/debugfs.c
+++ b/drivers/nvme/target/debugfs.c
@@ -13,7 +13,7 @@
  #include "nvmet.h"
  #include "debugfs.h"

-struct dentry *nvmet_debugfs;
+static struct dentry *nvmet_debugfs;

  #define NVMET_DEBUGFS_ATTR(field) \
      static int field##_open(struct inode *inode, struct file *file) \
-- 
2.40.0