linux-kernel - Re: [PATCH] selftests/bpf: Fix incorrect parameters in NULL pointer checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18138d48-3758-5aad-1d68-6250687f75f5@linux.dev>
Date: Fri, 23 Aug 2024 15:04:48 +0800
From: Hao Ge <hao.ge@...ux.dev>
To: Yonghong Song <yonghong.song@...ux.dev>
Cc: bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Hao Ge <gehao@...inos.cn>,
 Dan Carpenter <dan.carpenter@...aro.org>, andrii@...nel.org,
 martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org,
 john.fastabend@...il.com, kpsingh@...nel.org, haoluo@...gle.com,
 mykolal@...com, shuah@...nel.org, jolsa@...nel.org, sdf@...ichev.me,
 ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH] selftests/bpf: Fix incorrect parameters in NULL pointer
 checking

Hi Yonghong


Thank you very much for taking the time to review my patch.


On 8/22/24 05:03, Yonghong Song wrote:
>
> On 8/19/24 7:34 PM, Hao Ge wrote:
>> From: Hao Ge <gehao@...inos.cn>
>>
>> Smatch reported the following warning:
>>      ./tools/testing/selftests/bpf/testing_helpers.c:455 
>> get_xlated_program()
>>      warn: variable dereferenced before check 'buf' (see line 454)
>>
>> It seems correct,so let's modify it based on it's suggestion.
>>
>> Actually,commit b23ed4d74c4d ("selftests/bpf: Fix invalid pointer
>> check in get_xlated_program()") fixed an issue in the test_verifier.c
>> once,but it was reverted this time.
>>
>> Let's solve this issue with the minimal changes possible.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
>> Closes: 
>> https://lore.kernel.org/all/1eb3732f-605a-479d-ba64-cd14250cbf91@stanley.mountain/
>> Fixes: b4b7a4099b8c ("selftests/bpf: Factor out get_xlated_program() 
>> helper")
>> Signed-off-by: Hao Ge <gehao@...inos.cn>
>
> In the future, please change subject '[PATCH] ...' to '[PATCH 
> bpf-next] ...'
> so CI can properly test it.
>

OK, I understand. I will follow this rule in the future.


> Acked-by: Yonghong Song <yonghong.song@...ux.dev>
>