linux-kernel - Re: [PATCH] mmc : fix for check cqe halt.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bf83bab55ee44394e69696b5ac6be6e@manjaro.org>
Date: Fri, 23 Aug 2024 09:23:04 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Seunghwan Baek <sh8267.baek@...sung.com>
Cc: linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
 ulf.hansson@...aro.org, ritesh.list@...il.com, grant.jung@...sung.com,
 jt77.jang@...sung.com, junwoo80.lee@...sung.com, dh0421.hwang@...sung.com,
 jangsub.yi@...sung.com, sh043.lee@...sung.com, cw9316.lee@...sung.com,
 wkon.kim@...sung.com
Subject: Re: [PATCH] mmc : fix for check cqe halt.

On 2024-08-23 09:22, Dragan Simic wrote:
> Hello Seunghwan,
> 
> On 2024-08-23 09:10, Seunghwan Baek wrote:
>> To check if mmc cqe is in halt state, need to check
>> set/clear of CQHCI_HALT bit. At this time, we need to
>> check with &, not &&. Therefore, code to check whether
>> cqe is in halt state is modified to cqhci_halted,
>> which has already been implemented.
>> 
>> Signed-off-by: Seunghwan Baek <sh8267.baek@...sung.com>
> 
> Looking good to me, thanks for the patch.  I'd suggest that you
> resend the patch with a proper "Fixes" tag, together with the
> "Cc: stable@...r.kernel.org" tag.
> 
> Maybe also reflow the patch description a bit, to use the 78-column
> width or so fully.

Oh, and please feel free to include:

Reviewed-by: Dragan Simic <dsimic@...jaro.org>

>> ---
>>  drivers/mmc/host/cqhci-core.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/mmc/host/cqhci-core.c 
>> b/drivers/mmc/host/cqhci-core.c
>> index c14d7251d0bb..3d5bcb92c78e 100644
>> --- a/drivers/mmc/host/cqhci-core.c
>> +++ b/drivers/mmc/host/cqhci-core.c
>> @@ -282,7 +282,7 @@ static void __cqhci_enable(struct cqhci_host 
>> *cq_host)
>> 
>>  	cqhci_writel(cq_host, cqcfg, CQHCI_CFG);
>> 
>> -	if (cqhci_readl(cq_host, CQHCI_CTL) & CQHCI_HALT)
>> +	if (cqhci_halted(cq_host))
>>  		cqhci_writel(cq_host, 0, CQHCI_CTL);
>> 
>>  	mmc->cqe_on = true;
>> @@ -617,7 +617,7 @@ static int cqhci_request(struct mmc_host *mmc,
>> struct mmc_request *mrq)
>>  		cqhci_writel(cq_host, 0, CQHCI_CTL);
>>  		mmc->cqe_on = true;
>>  		pr_debug("%s: cqhci: CQE on\n", mmc_hostname(mmc));
>> -		if (cqhci_readl(cq_host, CQHCI_CTL) && CQHCI_HALT) {
>> +		if (cqhci_halted(cq_host)) {
>>  			pr_err("%s: cqhci: CQE failed to exit halt state\n",
>>  			       mmc_hostname(mmc));
>>  		}