linux-kernel - Re: [PATCH v2 05/36] soc: fsl: cpm1: tsa: Fix blank line and spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cf6e8ea-ded8-4cf7-b134-d54e1eedd559@csgroup.eu>
Date: Fri, 23 Aug 2024 10:04:37 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Herve Codina <herve.codina@...tlin.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Qiang Zhao <qiang.zhao@....com>,
 Li Yang <leoyang.li@....com>, Mark Brown <broonie@...nel.org>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 05/36] soc: fsl: cpm1: tsa: Fix blank line and spaces



Le 08/08/2024 à 09:10, Herve Codina a écrit :
> checkpatch.pl raises the following issues
>    CHECK: Please don't use multiple blank lines
>    CHECK: spaces preferred around that '/' (ctx:VxV)
>    CHECK: spaces preferred around that '+' (ctx:VxV)
>    CHECK: spaces preferred around that '-' (ctx:VxV)
> 
> Fix them.
> 
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>


> ---
>   drivers/soc/fsl/qe/tsa.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c
> index dc4dda17dab8..7b1032fb1572 100644
> --- a/drivers/soc/fsl/qe/tsa.c
> +++ b/drivers/soc/fsl/qe/tsa.c
> @@ -18,7 +18,6 @@
>   #include <linux/platform_device.h>
>   #include <linux/slab.h>
>   
> -
>   /* TSA SI RAM routing tables entry */
>   #define TSA_SIRAM_ENTRY_LAST		BIT(16)
>   #define TSA_SIRAM_ENTRY_BYTE		BIT(17)
> @@ -244,8 +243,8 @@ static void tsa_init_entries_area(struct tsa *tsa, struct tsa_entries_area *area
>   	resource_size_t quarter;
>   	resource_size_t half;
>   
> -	quarter = tsa->si_ram_sz/4;
> -	half = tsa->si_ram_sz/2;
> +	quarter = tsa->si_ram_sz / 4;
> +	half = tsa->si_ram_sz / 2;
>   
>   	if (tdms == BIT(TSA_TDMA)) {
>   		/* Only TDMA */
> @@ -408,7 +407,7 @@ static int tsa_of_parse_tdm_route(struct tsa *tsa, struct device_node *tdm_np,
>   		}
>   
>   		dev_dbg(tsa->dev, "tdm_id=%u, %s ts %u..%u -> %s\n",
> -			tdm_id, route_name, ts, ts+count-1, serial_name);
> +			tdm_id, route_name, ts, ts + count - 1, serial_name);
>   		ts += count;
>   
>   		ret = tsa_add_entry(tsa, &area, count, serial_id);