linux-kernel - Re: [PATCH v2 13/36] soc: fsl: cpm1: tsa: Introduce tsa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8fb1500-1228-4a95-a31a-7259fe39c179@csgroup.eu>
Date: Fri, 23 Aug 2024 10:08:14 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Herve Codina <herve.codina@...tlin.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Qiang Zhao <qiang.zhao@....com>,
 Li Yang <leoyang.li@....com>, Mark Brown <broonie@...nel.org>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 13/36] soc: fsl: cpm1: tsa: Introduce tsa_version



Le 08/08/2024 à 09:11, Herve Codina a écrit :
> Current code handles CPM1 version of TSA.
> 
> In order to prepare the support for the QUICC Engine (QE) version of
> TSA, introduce tsa_version to identify versions. This will enable the
> code to make the distinction between several TSA implementations.
> 
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>


> ---
>   drivers/soc/fsl/qe/tsa.c | 16 +++++++++++++++-
>   1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c
> index 48a176cece86..297721a0d2b6 100644
> --- a/drivers/soc/fsl/qe/tsa.c
> +++ b/drivers/soc/fsl/qe/tsa.c
> @@ -114,12 +114,17 @@ struct tsa_tdm {
>   #define TSA_TDMA	0
>   #define TSA_TDMB	1
>   
> +enum tsa_version {
> +	TSA_CPM1 = 1, /* Avoid 0 value */
> +};
> +
>   struct tsa {
>   	struct device *dev;
>   	void __iomem *si_regs;
>   	void __iomem *si_ram;
>   	resource_size_t si_ram_sz;
>   	spinlock_t	lock; /* Lock for read/modify/write sequence */
> +	enum tsa_version version;
>   	int tdms; /* TSA_TDMx ORed */
>   	struct tsa_tdm tdm[2]; /* TDMa and TDMb */
>   	struct tsa_serial {
> @@ -685,6 +690,15 @@ static int tsa_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	tsa->dev = &pdev->dev;
> +	tsa->version = (enum tsa_version)(uintptr_t)of_device_get_match_data(&pdev->dev);
> +	switch (tsa->version) {
> +	case TSA_CPM1:
> +		dev_info(tsa->dev, "CPM1 version\n");
> +		break;
> +	default:
> +		dev_err(tsa->dev, "Unknown version (%d)\n", tsa->version);
> +		return -EINVAL;
> +	}
>   
>   	for (i = 0; i < ARRAY_SIZE(tsa->serials); i++)
>   		tsa->serials[i].id = i;
> @@ -746,7 +760,7 @@ static void tsa_remove(struct platform_device *pdev)
>   }
>   
>   static const struct of_device_id tsa_id_table[] = {
> -	{ .compatible = "fsl,cpm1-tsa" },
> +	{ .compatible = "fsl,cpm1-tsa", .data = (void *)TSA_CPM1 },
>   	{} /* sentinel */
>   };
>   MODULE_DEVICE_TABLE(of, tsa_id_table);