linux-kernel - Re: [PATCH v2 20/36] soc: fsl: cpm1: qmc: Remove unneeded parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cc60804-0c93-4d29-8358-31771bdab246@csgroup.eu>
Date: Fri, 23 Aug 2024 10:09:56 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Herve Codina <herve.codina@...tlin.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Qiang Zhao <qiang.zhao@....com>,
 Li Yang <leoyang.li@....com>, Mark Brown <broonie@...nel.org>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 20/36] soc: fsl: cpm1: qmc: Remove unneeded parenthesis



Le 08/08/2024 à 09:11, Herve Codina a écrit :
> checkpatch.pl raises the following issue in several places
>    CHECK: Unnecessary parenthesis around ...
> 
> Remove them.
> 
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   drivers/soc/fsl/qe/qmc.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index 44bd9b949770..04466e735302 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -359,8 +359,8 @@ int qmc_chan_set_param(struct qmc_chan *chan, const struct qmc_chan_param *param
>   
>   	switch (param->mode) {
>   	case QMC_HDLC:
> -		if ((param->hdlc.max_rx_buf_size % 4) ||
> -		    (param->hdlc.max_rx_buf_size < 8))
> +		if (param->hdlc.max_rx_buf_size % 4 ||
> +		    param->hdlc.max_rx_buf_size < 8)
>   			return -EINVAL;
>   
>   		qmc_write16(chan->qmc->scc_pram + QMC_GBL_MRBLR,
> @@ -1152,7 +1152,7 @@ static int qmc_check_chans(struct qmc *qmc)
>   	if (ret)
>   		return ret;
>   
> -	if ((info.nb_tx_ts > 64) || (info.nb_rx_ts > 64)) {
> +	if (info.nb_tx_ts > 64 || info.nb_rx_ts > 64) {
>   		dev_err(qmc->dev, "Number of TSA Tx/Rx TS assigned not supported\n");
>   		return -EINVAL;
>   	}
> @@ -1161,7 +1161,7 @@ static int qmc_check_chans(struct qmc *qmc)
>   	 * If more than 32 TS are assigned to this serial, one common table is
>   	 * used for Tx and Rx and so masks must be equal for all channels.
>   	 */
> -	if ((info.nb_tx_ts > 32) || (info.nb_rx_ts > 32)) {
> +	if (info.nb_tx_ts > 32 || info.nb_rx_ts > 32) {
>   		if (info.nb_tx_ts != info.nb_rx_ts) {
>   			dev_err(qmc->dev, "Number of TSA Tx/Rx TS assigned are not equal\n");
>   			return -EINVAL;