linux-kernel - Re:Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

Open Source and information security mailing list archives

Message-ID: <4140b55c.a48.1917cc1095f.Coremail.andyshrk@163.com>
Date: Fri, 23 Aug 2024 09:01:51 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Cristian Ciocaltea" <cristian.ciocaltea@...labora.com>
Cc: "Conor Dooley" <conor@...nel.org>, 
	Heiko Stübner <heiko@...ech.de>, 
	"Andrzej Hajda" <andrzej.hajda@...el.com>, 
	"Neil Armstrong" <neil.armstrong@...aro.org>, 
	"Robert Foss" <rfoss@...nel.org>, 
	"Laurent Pinchart" <Laurent.pinchart@...asonboard.com>, 
	"Jonas Karlman" <jonas@...boo.se>, 
	"Jernej Skrabec" <jernej.skrabec@...il.com>, 
	"Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>, 
	"Maxime Ripard" <mripard@...nel.org>, 
	"Thomas Zimmermann" <tzimmermann@...e.de>, 
	"David Airlie" <airlied@...il.com>, 
	"Daniel Vetter" <daniel@...ll.ch>, 
	"Sandy Huang" <hjc@...k-chips.com>, 
	"Andy Yan" <andy.yan@...k-chips.com>, 
	"Rob Herring" <robh@...nel.org>, 
	"Krzysztof Kozlowski" <krzk+dt@...nel.org>, 
	"Conor Dooley" <conor+dt@...nel.org>, 
	"Mark Yao" <markyao0591@...il.com>, 
	"Sascha Hauer" <s.hauer@...gutronix.de>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org, 
	kernel@...labora.com, "Alexandre ARNOUD" <aarnoud@...com>, 
	"Luis de Arquer" <ldearquer@...il.com>
Subject: Re:Re: [PATCH v4 3/4] dt-bindings: display: rockchip: Add schema
 for RK3588 HDMI TX Controller

Hi，

在 2024-08-22 19:59:43，"Cristian Ciocaltea" <cristian.ciocaltea@...labora.com> 写道：
>On 8/22/24 11:41 AM, Conor Dooley wrote:
>> On Thu, Aug 22, 2024 at 09:01:34AM +0200, Heiko Stübner wrote:
>>> @Conor: just for me, did some shift happen in our understanding of dt-
>>> best-practices in terms of syscon via phandle vs. syscon via compatible?
>>>
>>> Because Rockchip boards are referencing their GRFs via phandes forever
>>> but similar to the soc vs non-soc node thing, I'd like to stay on top of
>>> best-practices ;-)
>> 
>> If IP blocks, and thus drivers, are going to be reused between devices,
>> using the phandles makes sense given that it is unlikely that syscon
>> nodes can make use of fallback compatibles due to bits within that "glue"
>> changing between devices. It also makes sense when there are multiple
>> instances of an IP on the device, which need to use different syscons.
>> My goal is to ask people why they are using these type of syscons
>> phandle properties, cos often they are not required at all - for example
>> with clocks where you effectively need a whole new driver for every
>> single soc and having a phandle property buys you nothing.
>
>That would be also the case for this HDMI controller - need to check the
>specs for the newer RK3576 SoC, but I expect the syscons would be quite
>different when compared to RK3588, hence we should keep making use of
>the phandles.

Yes，for rk3576，it shares the same HDMI IP block（hdmi controller and PHY），
of course reuse the driver of rk3588， but it has different GRF to depends on[0]:
which calls ioc_grf and vo0_grf:

I also believe that makeing use of phandle beneficial for different devices to reuse the same code.

hdmi: hdmi@...a0000 {
                compatible = "rockchip,rk3576-dw-hdmi";
                reg = <0x0 0x27da0000 0x0 0x10000>, <0x0 0x27db0000 0x0 0x10000>;
                interrupts = <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>,
                             <GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH>,
                             <GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH>,
                             <GIC_SPI 341 IRQ_TYPE_LEVEL_HIGH>,
                             <GIC_SPI 367 IRQ_TYPE_LEVEL_HIGH>;
,            rockchip,grf = <&ioc_grf>;
             rockchip,vo0_grf = <&vo0_grf>;
             phys = <&hdptxphy_hdmi>;
             phy-names = "hdmi";

[0]https://github.com/armbian/linux-rockchip/blob/rk-6.1-rkr3/arch/arm64/boot/dts/rockchip/rk3576.dtsi#L3122C2-L3123C33

>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@...ts.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives