linux-kernel - Re: [PATCH v2 22/36] soc: fsl: cpm1: qmc: Add missing spinlock comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <447b75e4-6a25-4756-a37e-dbe46091ef76@csgroup.eu>
Date: Fri, 23 Aug 2024 10:10:45 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Herve Codina <herve.codina@...tlin.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Qiang Zhao <qiang.zhao@....com>,
 Li Yang <leoyang.li@....com>, Mark Brown <broonie@...nel.org>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 22/36] soc: fsl: cpm1: qmc: Add missing spinlock
 comment



Le 08/08/2024 à 09:11, Herve Codina a écrit :
> checkpatch.pl raises the following issue
>    CHECK: spinlock_t definition without comment
> 
> Add the missing comments.
> 
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   drivers/soc/fsl/qe/qmc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index 2d54d7400d2d..3736a8e4575e 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -196,7 +196,7 @@ struct qmc_chan {
>   	u64	rx_ts_mask;
>   	bool is_reverse_data;
>   
> -	spinlock_t	tx_lock;
> +	spinlock_t	tx_lock; /* Protect Tx related data */
>   	cbd_t __iomem *txbds;
>   	cbd_t __iomem *txbd_free;
>   	cbd_t __iomem *txbd_done;
> @@ -204,7 +204,7 @@ struct qmc_chan {
>   	u64	nb_tx_underrun;
>   	bool	is_tx_stopped;
>   
> -	spinlock_t	rx_lock;
> +	spinlock_t	rx_lock; /* Protect Rx related data */
>   	cbd_t __iomem *rxbds;
>   	cbd_t __iomem *rxbd_free;
>   	cbd_t __iomem *rxbd_done;