[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240823092959.00000c90@Huawei.com>
Date: Fri, 23 Aug 2024 09:29:59 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Yang Ruibin <11162571@...o.com>
CC: Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>, "Andy
Whitcroft" <apw@...onical.com>, Joe Perches <joe@...ches.com>, "Dwaipayan
Ray" <dwaipayanray1@...il.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, Ingo
Molnar <mingo@...nel.org>, <linux-edac@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <opensource.kernel@...o.com>
Subject: Re: [PATCH v2] drivers:block:Use IS_ERR() to check
debugfs_create_dir() return value
On Thu, 22 Aug 2024 21:23:58 +0800
Yang Ruibin <11162571@...o.com> wrote:
Patch title needs an update as this isn't in block and that's not the
style used for this subsystem.
Otherwise fine.
> The debugfs_create_dir() function returns error pointers.It
> never returns NULL. So use IS_ERR() to check its return value.
>
> Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
> Signed-off-by: Yang Ruibin <11162571@...o.com>
> ---
> drivers/ras/cec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
> index e440b15fbabc..ebd4631b685b 100644
> --- a/drivers/ras/cec.c
> +++ b/drivers/ras/cec.c
> @@ -489,7 +489,7 @@ static int __init create_debugfs_nodes(void)
> }
>
> d = debugfs_create_dir("cec", dfs);
> - if (!d) {
> + if (IS_ERR(d)) {
> pr_warn("Error creating cec debugfs node!\n");
> return -1;
> }
Powered by blists - more mailing lists