linux-kernel - [PATCH v2 1/1] drm/panel: fix null pointer dereference in hx83102_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240823083657.7100-1-hanchunchao@inspur.com>
Date: Fri, 23 Aug 2024 16:36:57 +0800
From: Charles Han <hanchunchao@...pur.com>
To: <neil.armstrong@...aro.org>, <yangcong5@...qin.corp-partner.google.com>,
	<quic_jesszhan@...cinc.com>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <tzimmermann@...e.de>
CC: <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<liuyanming@...system.com>, Charles Han <hanchunchao@...pur.com>
Subject: [PATCH v2 1/1] drm/panel: fix null pointer dereference in hx83102_get_modes

In hx83102_get_modes(), the return value of drm_mode_duplicate() is
assigned to mode, which will lead to a possible NULL pointer
dereference on failure of drm_mode_duplicate(). Add a check to avoid
npd.

Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102: Break out as  separate driver")
Signed-off-by: Charles Han <hanchunchao@...pur.com>
---
 drivers/gpu/drm/panel/panel-himax-hx83102.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-himax-hx83102.c b/drivers/gpu/drm/panel/panel-himax-hx83102.c
index 7c2a5e9b7fb3..e61ed7d02729 100644
--- a/drivers/gpu/drm/panel/panel-himax-hx83102.c
+++ b/drivers/gpu/drm/panel/panel-himax-hx83102.c
@@ -566,7 +566,6 @@ static int hx83102_get_modes(struct drm_panel *panel,
 
 	mode = drm_mode_duplicate(connector->dev, m);
 	if (!mode) {
-		dev_err(&ctx->dsi->dev, "bad mode or failed to add mode\n");
 		return -EINVAL;
 	}
 
-- 
2.31.1